Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure --output-dir always exists #891

Merged
merged 2 commits into from
Nov 8, 2024
Merged

Ensure --output-dir always exists #891

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
088e34b
Ensure output_dir always exists
jaimergp Nov 8, 2024
ba80691
add news
jaimergp Nov 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions constructor/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,6 +241,7 @@ def main_build(dir_path, output_dir='.', platform=cc_platform,
# '_dists': List[Dist]
# '_urls': List[Tuple[url, md5]]

os.makedirs(output_dir, exist_ok=True)
info_dicts = []
for itype in itypes:
if itype == 'sh':
Expand Down
19 changes: 19 additions & 0 deletions news/891-output-dir
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
### Enhancements

* <news item>

### Bug fixes

* Do not crash if `--output-dir` doesn't exist. Ensure it does before creating installers. (#772 via #891)

### Deprecations

* <news item>

### Docs

* <news item>

### Other

* <news item>
Loading