-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add extra pages to pkg installers #852
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conda-bot
added
the
cla-signed
[bot] added once the contributor has signed the CLA
label
Sep 6, 2024
…into pkg-extra-pages
jaimergp
reviewed
Sep 10, 2024
jaimergp
reviewed
Sep 10, 2024
jaimergp
reviewed
Sep 10, 2024
jaimergp
reviewed
Sep 10, 2024
jaimergp
reviewed
Sep 10, 2024
jaimergp
reviewed
Sep 10, 2024
jaimergp
reviewed
Sep 10, 2024
jaimergp
approved these changes
Sep 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Summary of changes
Detailed explanation
constructor
has the capability to add additional pages for exe installer by overloading thecustom_conclusion
property. This is not possible forpkg
installer because custom pages have a different format from conclusion pages: extra pages follow the Apple plugins format whereas conclusions are RTF or HTML.So, a new keyword for
construct.yaml
is required. For pkg installer, this keyword can take multiple extra pages and add them to a pkg installer. These pages can either be compiled projects or simple, single-target projects. The latter is helpful for repositories since it would not require committing binaries.The plugins must be signed to pass notarization just like the
_conda
binary. To make the code DRYer, thecodesign
commands are now a class just like the Windows signing tools. Caveat:get_signing_command()
has a different return type because they are used differently. However, I'm happy to change the Windows return type tolist
and do the join operation elsewhere.Signing has not been tested on MacOS yet. The challenge is to create self-signed certificates that must be added to a keychain. This is limited to application signing. For installers, a certificate has to be trusted to be found in the keychain. Trusting a certificate requires authentication and interaction with keychains, causing the job to be stuck. I have not found a way to circumvent this.
This concept has been expanded to Windows as well. While this can still be done via
custom_conclusion
, using the extra pages keyword provides a cleaner solution, especially for those who use the default conclusion page.Checklist - did you ...
news
directory (using the template) for the next release's release notes?