-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
catch install-time errors on windows #553
Conversation
Finally, we have eyes on Windows :D This is ready for review now. |
Note Windows are now failing, as reported in #544
Edit: looks like the fix is simpler! I had forgotten a block in the NSI template. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM +1 for merge
Thanks @jaimergp! |
Description
Closes #544
Closes #551
In #509 I forgot to add one piece of the conda packages extraction logic. This resulted in failed installs. Readding this piece fixes #544.
However, this error wasn't caught by the CI pipeline because of #551!
Note that the silent mode of NSIS installers (
/S
) does not print anything to STDOUT. Additionally, most of the dialogs are configured to "ignore" the warning if an error occurred, thus moving on. The exit code does not change with errors! We can't rely on that to detect whether something failed. Instead, the solution was:*log*
variants to thensis
package in conda-forge/defaults, but for now we are manually patching.conda install ...
step will throw an error too, if needed (it didn't before!):error:
strings planted by our NSI scriptChecklist - did you ...
news
directory (using the template) for the next release's release notes?