progress_notifications must be bool

conda · Nov 17, 2024 · edbdbf1 · edbdbf1
1 parent 95976ec
commit edbdbf1
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 4 deletions.
diff --git a/constructor/osx/prepare_installation.sh b/constructor/osx/prepare_installation.sh
@@ -8,7 +8,7 @@ set -euo pipefail
 
 notify() {
 # shellcheck disable=SC2050
-{%- if progress_notifications == "true" %}
+{%- if progress_notifications %}
 osascript <<EOF
 display notification "$1" with title "📦 Install {{ installer_name }} {{ installer_version }}"
 EOF

diff --git a/constructor/osx/run_installation.sh b/constructor/osx/run_installation.sh
@@ -10,7 +10,7 @@ set -euo pipefail
 
 notify() {
 # shellcheck disable=SC2050
-{%- if progress_notifications == "true" %}
+{%- if progress_notifications %}
 osascript <<EOF
 display notification "$1" with title "📦 Install __NAME__ __VERSION__"
 EOF

diff --git a/constructor/osx/run_user_script.sh b/constructor/osx/run_user_script.sh
@@ -8,7 +8,7 @@ set -euo pipefail
 
 notify() {
 # shellcheck disable=SC2050
-{%- if progress_notifications == "true" %}
+{%- if progress_notifications %}
 osascript <<EOF
 display notification "$1" with title "📦 Install __NAME__ __VERSION__"
 EOF

diff --git a/constructor/osxpkg.py b/constructor/osxpkg.py
@@ -338,7 +338,7 @@ def move_script(src, dst, info, ensure_shebang=False, user_script_type=None):
     variables["channels"] = ','.join(get_final_channels(info))
     variables["write_condarc"] = '\n'.join(add_condarc(info))
     variables["path_exists_error_text"] = path_exists_error_text
-    variables["progress_notifications"] = str(info.get('progress_notifications', False))
+    variables["progress_notifications"] = info.get('progress_notifications', False)
     variables["pre_or_post"] = user_script_type or '__PRE_OR_POST__'
     variables["constructor_version"] = info['CONSTRUCTOR_VERSION']
     variables["shortcuts"] = shortcuts_flags(info)