Apply suggestions from code review

conda · Nov 17, 2024 · 1e6496b · 1e6496b
1 parent f7bcd15
commit 1e6496b
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/constructor/shar.py b/constructor/shar.py
@@ -85,8 +85,8 @@ def get_header(conda_exec, tarball, info):
     variables['installer_platform'] = info['_platform']
     variables['installer_md5'] = hash_files([conda_exec, tarball])
     variables['default_prefix'] = info.get('default_prefix', '${HOME:-/opt}/%s' % name.lower())
-    variables['first_payload_size'] = str(getsize(conda_exec))
-    variables['second_payload_size'] = str(getsize(tarball))
+    variables['first_payload_size'] = getsize(conda_exec)
+    variables['second_payload_size'] = getsize(tarball)
     variables['install_commands'] = '\n'.join(install_lines)
     variables['channels'] = ','.join(get_final_channels(info))
     variables['conclusion_text'] = info.get("conclusion_text", "installation finished.")

diff --git a/constructor/winexe.py b/constructor/winexe.py
@@ -347,7 +347,7 @@ def make_nsi(
     variables['SIGNTOOL_COMMAND'] = signing_tool.get_signing_command() if signing_tool else ""
     variables['SETUP_ENVS'] = '\n    '.join(setup_envs_commands(info, dir_path))
     variables['WRITE_CONDARC'] = '\n    '.join(add_condarc(info))
-    variables['SIZE'] = str(approx_pkgs_size_kb)
+    variables['SIZE'] = approx_pkgs_size_kb
     variables['UNINSTALL_NAME'] = info.get(
         'uninstall_name',
         '${NAME} ${VERSION} (Python ${PYVERSION} ${ARCH})'