Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip tests that require sudo if sudo is unavailable #126

Merged
merged 2 commits into from
Jan 16, 2025

Conversation

marcoesters
Copy link
Contributor

Description

Some CIs do not run as root and do not allow sudo to be used, which causes test failures in some uninstallation tests. If a test requires sudo, test if sudo can be executed by the user and skip the test if not.

Note: the CI here will not show different behavior since the user on GitHub runners is root. I tested it on a virtual Debian though.

Closes #120.

Checklist - did you ...

  • Add a file to the news directory (using the template) for the next release's release notes?
  • Add / update necessary tests?
  • Add / update outdated documentation?

@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Jan 8, 2025
@marcoesters marcoesters marked this pull request as ready for review January 8, 2025 23:01
@marcoesters marcoesters requested a review from a team as a code owner January 8, 2025 23:01
@marcoesters marcoesters merged commit 0957b3d into conda:main Jan 16, 2025
8 checks passed
@marcoesters marcoesters deleted the skip-tests-without-sudo branch January 16, 2025 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed [bot] added once the contributor has signed the CLA
Projects
Status: 🏁 Done
Development

Successfully merging this pull request may close these issues.

Skip uninstaller tests requiring sudo if sudo is not allowed
3 participants