Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace _get_temp_prefix with path_factory #529

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

kenodegard
Copy link
Contributor

@kenodegard kenodegard commented Sep 21, 2024

Description

Replace _get_temp_prefix with path_factory/session_path_factory fixtures.

Removes unused:

  • tests/channel_testing/helpers.py::create_with_channel_in_process
  • tests/test_experimental.py::_get_temp_prefix_safe
  • tests/test_experimental.py::cli_flag_and_env_var_settings
  • tests/test_performance.py::_tmp_prefix_safe

Xref #524
Xref conda/conda#14243

Checklist - did you ...

  • Add a file to the news directory (using the template) for the next release's release notes?
  • Add / update necessary tests?
  • Add / update outdated documentation?

Removes unused:
- tests/channel_testing/helpers.py::create_with_channel_in_process
- tests/test_experimental.py::_get_temp_prefix_safe
- tests/test_experimental.py::cli_flag_and_env_var_settings
- tests/test_performance.py::_tmp_prefix_safe
@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Sep 21, 2024
@jaimergp
Copy link
Contributor

@kenodegard - this is ready to merge if you want, but it's still mark as draft?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed [bot] added once the contributor has signed the CLA
Projects
Status: 🆕 New
Development

Successfully merging this pull request may close these issues.

4 participants