add jlap utility ported from repodata-fly #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conda-bot
added
the
cla-signed
dholth
changed the title
dholth
commented
May 14, 2024
conda_index/cli/json2jlap.py
Outdated
|
|
||
| if ( | ||
| previous_repodata.exists() | ||
| and repodata.stat().st_mtime_ns > previous_repodata.stat().st_mtime_ns |
jezdez
approved these changes
May 28, 2024
Comment on lines
+197
to
+207
| def go(): | ||
| logging.basicConfig( | ||
| format="%(message)s", | ||
| datefmt="%Y-%m-%dT%H:%M:%S", | ||
| level=logging.INFO, | ||
| ) | ||
| json2jlap() | ||
|
|
||
|
|
||
| if __name__ == "__main__": | ||
| go() |
There was a problem hiding this comment.
Suggested change
| def go(): | |
| logging.basicConfig( | |
| format="%(message)s", | |
| datefmt="%Y-%m-%dT%H:%M:%S", | |
| level=logging.INFO, | |
| ) | |
| json2jlap() | |
| if __name__ == "__main__": | |
| go() | |
| def main(): | |
| logging.basicConfig( | |
| format="%(message)s", | |
| datefmt="%Y-%m-%dT%H:%M:%S", | |
| level=logging.INFO, | |
| ) | |
| json2jlap() | |
| if __name__ == "__main__": | |
| main() |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #125
This is more elegant than the repodata-fly version since it uses the same implementation, a list of
[(position, line, checksum), ...]for both collecting patches and trimming the file. We avoid having to save and load the file just to do a trim.Description
Checklist - did you ...
newsdirectory (using the template) for the next release's release notes?