Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing test: test_skeleton_pypi #5577

Merged
merged 3 commits into from
Jan 7, 2025
Merged

Conversation

jaimergp
Copy link
Contributor

@jaimergp jaimergp commented Jan 6, 2025

Description

As seen in other CI runs, click removed setup.py in 8.1.8, so let's use an older version because this file is expected by the test.

Checklist - did you ...

  • Add a file to the news directory (using the template) for the next release's release notes?
  • Add / update necessary tests?
  • Add / update outdated documentation?

@jaimergp jaimergp requested a review from a team as a code owner January 6, 2025 16:51
@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Jan 6, 2025
Copy link

codspeed-hq bot commented Jan 6, 2025

CodSpeed Performance Report

Merging #5577 will not alter performance

Comparing jaimergp:click-fix (ba35b70) with main (9c253dc)

Summary

✅ 5 untouched benchmarks

kenodegard
kenodegard previously approved these changes Jan 6, 2025
@jaimergp
Copy link
Contributor Author

jaimergp commented Jan 6, 2025

FAILED tests/test_api_build.py::test_croot_with_spaces - libmambapy.bindings.specs.ParseError: Failed to parse URL "file:///D:/a/_temp/popen-gw0/test_croot_with_spaces0/space path": Malformed input to a URL function

is an error in libmamba v2 that will have to be fixed in conda-libmamba-solver, most likely. Shouldn't be a merge blocker. Opened mamba-org/mamba#3730.

@isuruf isuruf enabled auto-merge (squash) January 7, 2025 07:03
@isuruf
Copy link
Contributor

isuruf commented Jan 7, 2025

New failure:

FAILED tests/test_api_build.py::test_recipe_builds[entry_points_have_prefix] - conda.CondaMultiError: Error with archive /home/runner/conda_pkgs_dir/setuptools-75.1.0-py311h06a4308_0.conda.  You probably need to delete and re-download or re-create this file.  Message was:

Let's get this merged to unblock PRs

@isuruf isuruf disabled auto-merge January 7, 2025 09:58
@isuruf isuruf enabled auto-merge (squash) January 7, 2025 09:58
@isuruf isuruf disabled auto-merge January 7, 2025 09:59
@isuruf
Copy link
Contributor

isuruf commented Jan 7, 2025

I can't merge without the required statuses passing. Can someone with the correct permissions merge? @conda/builds-tools

@jaimergp
Copy link
Contributor Author

jaimergp commented Jan 7, 2025

FAILED tests/test_api_build.py::test_recipe_builds[entry_points_have_prefix] - conda.CondaMultiError: Error with archive /home/runner/conda_pkgs_dir/setuptools-75.1.0-py311h06a4308_0.conda. You probably need to delete and re-download or re-create this file. Message was:

This one is a flaky one. Rerunning the CI usually helps.

I can't merge without the required statuses passing. Can someone with the correct permissions merge?

Me neither. We will need to skip the offending tests for a bit. Let me push something.

@beckermr
Copy link
Contributor

beckermr commented Jan 7, 2025

We could consider adding retries via the flaky package. I use this in the bot and it helps a bit.

@kenodegard kenodegard enabled auto-merge (squash) January 7, 2025 14:45
@kenodegard kenodegard merged commit b8724c6 into conda:main Jan 7, 2025
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed [bot] added once the contributor has signed the CLA
Projects
Status: 🏁 Done
Development

Successfully merging this pull request may close these issues.

5 participants