Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pre-commit.ci] pre-commit autoupdate #5554

Merged
merged 3 commits into from
Nov 26, 2024
Merged

Conversation

pre-commit-ci[bot]
Copy link
Contributor

@pre-commit-ci pre-commit-ci bot commented Nov 25, 2024

updates:
- [github.com/astral-sh/ruff-pre-commit: v0.7.4 → v0.8.0](astral-sh/ruff-pre-commit@v0.7.4...v0.8.0)
@pre-commit-ci pre-commit-ci bot requested a review from a team as a code owner November 25, 2024 16:34
@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Nov 25, 2024
beeankha
beeankha previously approved these changes Nov 25, 2024
@jaimergp
Copy link
Contributor

A few errors for UP031 Use format specifiers instead of percent format. Shall we fix or add this to the ignore list, @conda/builds-tools?

@beckermr
Copy link
Contributor

Per-line ignores seems best. I don't like touching old code around here.

@beckermr beckermr requested a review from a team November 26, 2024 10:50
Copy link

codspeed-hq bot commented Nov 26, 2024

CodSpeed Performance Report

Merging #5554 will not alter performance

Comparing pre-commit-ci-update-config (7cfb19c) with main (8d0ca34)

Summary

✅ 5 untouched benchmarks

@beckermr
Copy link
Contributor

Any comments here @conda/builds-tools?

@beeankha
Copy link
Member

Should we do something like this instead?

@beckermr
Copy link
Contributor

The idea I had was to leave old code in place, but ensure new code is updated. The noqa markers will let us find the few instances of the older style should we want to fix them.

@beeankha beeankha merged commit 8e32fce into main Nov 26, 2024
28 checks passed
@beeankha beeankha deleted the pre-commit-ci-update-config branch November 26, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed [bot] added once the contributor has signed the CLA
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants