Add an option to create arch specific, python version independent pkgs #5456
Conversation
conda-bot
added
the
cla-signed
isuruf
force-pushed
the
python-ver-indep
branch
from
65657d8 to
0e05755
Compare
CodSpeed Performance ReportMerging #5456 will not alter performanceComparing Summary
|
isuruf
force-pushed
the
python-ver-indep
branch
from
90a41d0 to
7f8a9ed
Compare
isuruf
force-pushed
the
python-ver-indep
branch
from
aa23fdd to
fa7b1bb
Compare
|
Thanks for the docs! We are missing the |
|
Thanks. Added a news entry and updated the PR description. |
|
Awesome work! |
| if target_file.find("site-packages") >= 0: | ||
| return target_file[target_file.find("site-packages") :] | ||
| elif target_file.startswith("bin") and ( | ||
| if target_file.startswith("bin") and ( |
There was a problem hiding this comment.
Should this include the slash to prevent matches with paths like binocular.dat?
| if target_file.startswith("bin") and ( | |
| if target_file.startswith("bin/") and ( |
(And in that case, update the replace below?)
There was a problem hiding this comment.
Let's leave it for a different PR?
| if target_file.find("site-packages") >= 0: | ||
| return target_file[target_file.find("site-packages") :] | ||
| elif target_file.startswith("bin") and ( | ||
| if target_file.startswith("bin") and ( | ||
| target_file not in entry_point_script_names | ||
| ): | ||
| return target_file.replace("bin", "python-scripts") |
There was a problem hiding this comment.
| return target_file.replace("bin", "python-scripts") | |
| return target_file.replace("bin/", "python-scripts/") |
conda_build/metadata.py
Outdated
| # This is a hack to make conda/mamba/micromamba compile the pure python files | ||
| # and for micromamba to move the files in site-packages to the correct dir. |
There was a problem hiding this comment.
Which versions require this hack? All of them?
There was a problem hiding this comment.
I added a clarification to the comment here.
| python_version_independent: true | ||
|
|
||
| A package builder also has to indicate which standard is supported by | ||
| the package, i.e., for ABI3, |
There was a problem hiding this comment.
| the package, i.e., for ABI3, | |
| the package, i.e., for ABI3 in conda-forge |
AFAIK, python-abi3 is a conda-forge-specific package, right? Or is it in defaults too?
There was a problem hiding this comment.
We should add it to defaults too.
There was a problem hiding this comment.
@chenghlee do you think it's reasonable to add this package to defaults? Otherwise I'll update this PR to reflect that the package is only in conda-forge.
Co-authored-by: jaimergp <[email protected]>
Co-authored-by: Jannis Leidel <[email protected]> Co-authored-by: jaimergp <[email protected]>
Co-authored-by: jaimergp <[email protected]>
Description
Checklist - did you ...
newsdirectory (using the template) for the next release's release notes?Implementation for ABI3 as described in https://github.com/conda/ceps/blob/main/cep-0020.md
This implementation depends on a specific
python-abi3package (already in conda-forge at https://github.com/conda-forge/python-abi3-feedstock) in host to set the correct runtime dependencies.By being ABI3 agnostic, we leave room for other standards like ABI4, HPy to be supported.
Added documentation has an example, and a more complicated example for conda-forge is at https://github.com/conda-forge/python-abi3-feedstock/blob/main/recipe/example-meta.yaml