-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor which_package & which_prefix #5041
Merged
Merged
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
bada3b1
Refactor which_package & which_prefix
kenodegard 0a52fd0
Update utils.py
kenodegard 1754e97
Ensure prefix passed to PrefixData is str
kenodegard 8cc2846
Merge branch 'main' into which_package
kenodegard dabe799
Merge branch 'main' into which_package
kenodegard 12bf2da
Minor
kenodegard 97d000c
More Dist -> PrefixRecord replacements
kenodegard 5ab0a40
Corrections
kenodegard 04ca48d
Merge branch 'main' into which_package
kenodegard f204147
Remove is_linked usage
kenodegard c24d662
More cleanup
kenodegard bbaadc1
Fix print_linkages
kenodegard 85ba9c2
Better samefile detection
kenodegard 57b7b71
Add news
kenodegard File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
linked_data_no_multichannels
andlinked_data
do the following:since this PR eliminates the poor
PrefixRecord
→Dist
translation I don't believe there's a need to distinguish betweenavoid_canonical_channel_name
anymore (not that I'm entirely sure what that means in the first place)