Add test for conda_build.metadata.get_selectors
#5024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conda-bot
added
the
cla-signed
isuruf
previously approved these changes
Oct 3, 2023
kenodegard
force-pushed
the
test_get_selectors
branch
from
2314936 to
314b8df
Compare
beeankha
approved these changes
Oct 3, 2023
3 tasks
3 tasks
|
Adding this new test unearthed an issue with unrelated tests that needs addressing first: #5036 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding test to confirm we aren't loosing any selectors with the proposed change in #5009.
Corrects
py3kselector to correctly evaluated to True for all Python 3 versions. While thepy*selectors are deprecated (see #4032, #4297, and #4324) in favor of thepyselector there's no reason for the deprecated selectors to be incorrect.Checklist - did you ...
Add a file to thenewsdirectory (using the template) for the next release's release notes?Add / update outdated documentation?