Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Zstd compression default to 19 #4663

Merged
merged 2 commits into from
Dec 2, 2022
Merged

Change Zstd compression default to 19 #4663

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
866c87e
Change Zstd compression default to 19
jakirkham Dec 1, 2022
ad4f589
Use variable in CLI message
jakirkham Dec 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion conda_build/cli/main_build.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,8 @@ def parse_args(args):
p.add_argument(
"--zstd-compression-level",
help=("When building v2 packages, set the compression level used by "
"conda-package-handling. Defaults to the maximum."),
"conda-package-handling. "
f"Defaults to {zstd_compression_level_default}."),
type=int,
choices=range(1, 23),
default=cc_conda_build.get('zstd_compression_level', zstd_compression_level_default),
Expand Down
2 changes: 1 addition & 1 deletion conda_build/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ def set_invocation_time():
ignore_verify_codes_default = []
exit_on_verify_error_default = False
conda_pkg_format_default = None
zstd_compression_level_default = 22
zstd_compression_level_default = 19


# Python2 silliness:
Expand Down
19 changes: 19 additions & 0 deletions news/zstd_def_19
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
### Enhancements

* <news item>

### Bug fixes

* Change Zstd default compression to 19

### Deprecations

* <news item>

### Docs

* <news item>

### Other

* <news item>