-
Notifications
You must be signed in to change notification settings - Fork 427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use conda.base.constants.KNOWN_SUBDIRS for setting up selectors #5009
Conversation
pre-commit.ci autofix |
I see #5024. I had a little fear that we could loose some selectors by accident since the I think the last thing would probably be to document that the supported subdirs come from conda. We might also want to go over https://docs.conda.io/projects/conda-build/en/stable/resources/define-metadata.html#preprocessing-selectors and update and add the supported selectors? |
for more information, see https://pre-commit.ci
Yes, I think that table is missing wasi, emscriptem and other recently added architectures. I wonder how tricky would be to autogenerate it like it's done in |
Co-authored-by: Isuru Fernando <[email protected]>
Description
Refactor
conda_build.metadata.get_selectors
to useconda.base.constants.KNOWN_SUBDIRS
instead of duplicating this list inconda_build
. Furthermore, abstract the selector generation so theres less effort to add new OS/Archs in the future.Checklist - did you ...
news
directory (using the template) for the next release's release notes?