Support SHA224, SHA384 and SHA512 source hashes. #4793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conda-bot
added
the
cla-signed
10 tasks
kenodegard
requested changes
Feb 26, 2024
Co-authored-by: Ken Odegard <[email protected]>
|
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
kenodegard
reviewed
Feb 26, 2024
kenodegard
previously approved these changes
Feb 26, 2024
beeankha
previously approved these changes
Feb 27, 2024
CodSpeed Performance ReportMerging #4793 will not alter performanceComparing Summary
|
beeankha
previously approved these changes
Jun 10, 2024
3 tasks
jaimergp
reviewed
Nov 26, 2024
jaimergp
reviewed
Nov 26, 2024
| ) | ||
| break |
There was a problem hiding this comment.
This is interesting, we were only computing the weakest one and ignoring the rest?
jaimergp
reviewed
Nov 26, 2024
Co-authored-by: jaimergp <[email protected]>
Co-authored-by: jaimergp <[email protected]>
|
This is ready for another look @jaimergp! |
jaimergp
approved these changes
Nov 26, 2024
|
Thanks for taking over @beckermr |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Provides support for validating source checksums via SHA224, SHA384 and SHA512, in addition to the existing MD5, SHA1 and SHA256 options. A similar request has been made for
boa(see here).In addition, when multiple checksums are provided in the recipe, a
RuntimeErrorwill now be raised if any of the checksums are wrong. Previously, this error would not necessarily be raised if one of the provided checksums was valid (if this was an intentional design choice then this part can be reverted/excluded from the pull).Documentation and appropriate test-recipes have been updated to include examples of using the new checksums.
Checklist - did you ...
newsdirectory (using the template) for the next release's release notes?