Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARM OSX Migrator #165

Merged

Conversation

regro-cf-autotick-bot
Copy link
Contributor

This feedstock is being rebuilt as part of the ARM OSX migration.

Feel free to merge the PR if CI is all green, but please don't close it
without reaching out the the ARM OSX team first at @conda-forge/help-osx-arm64.

If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase @conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by - please use this URL for debugging.

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

  • It looks like the 'libxgboost' output doesn't have any tests.
  • It looks like the '_py-xgboost-mutex' output doesn't have any tests.
  • It looks like the 'py-xgboost-cpu' output doesn't have any tests.
  • It looks like the 'py-xgboost-gpu' output doesn't have any tests.
  • It looks like the 'xgboost' output doesn't have any tests.
  • It looks like the '_r-xgboost-mutex' output doesn't have any tests.
  • It looks like the 'r-xgboost-cpu' output doesn't have any tests.
  • It looks like the 'r-xgboost-gpu' output doesn't have any tests.

Copy link
Member

@jakirkham jakirkham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feedstock was already migrated for macOS ARM in PR ( #79 ). However there are some other fixes that are unrelated to that migration, which are useful as noted below. So will go ahead and merge

Comment on lines 1 to +4
MACOSX_DEPLOYMENT_TARGET:
- '10.9'
- '10.13'
MACOSX_SDK_VERSION:
- '10.13'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just updating the macOS minimum to 10.13, which is inline with this work ( conda-forge/conda-forge.github.io#1844 )

@jakirkham
Copy link
Member

@conda-forge-admin , please re-render

1 similar comment
@jakirkham
Copy link
Member

@conda-forge-admin , please re-render

@hcho3 hcho3 merged commit 5c1e0fe into conda-forge:main May 29, 2024
16 checks passed
Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/xgboost-feedstock/actions/runs/9292041268.

hcho3 pushed a commit to dantegd/rapids-xgboost-feedstock that referenced this pull request May 29, 2024
@regro-cf-autotick-bot regro-cf-autotick-bot deleted the bot-pr_arm_osx_hde9d30 branch May 29, 2024 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants