-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MNT: Use noarch python {{ python_min }} variable #161
MNT: Use noarch python {{ python_min }} variable #161
Conversation
* Use 'python {{ python_min }}' syntax for the 'host' python requirement for noarch python recipes. - c.f. https://conda-forge.org/docs/maintainer/knowledge_base/#noarch-python * Bump build number.
@conda-forge-admin, please rerender |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( For recipe/meta.yaml:
|
Hi! This is the friendly automated conda-forge-webservice. I tried to rerender for you, but it looks like there was nothing to do. This message was generated by GitHub actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/11733592006. |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@conda-forge-admin, please rerender |
…nda-forge-pinning 2024.11.07.16.38.57
.ci_support/linux_64_.yaml
Outdated
python_min: | ||
- '3.9' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You may need to override the python_min variable in the
conda_build_config.yaml
/variants.yaml
if the package requires a newer Python version than the currently supported minimum version on conda-forge.
Okay, so I now need to figure out how to override python_min
as to be '3.8'
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@beckermr @chrisburr @jakirkham This isn't very clear from https://docs.conda.io/projects/conda-build/en/latest/resources/variants.html#general-pinning-examples (as there's nothing on this in https://conda-forge.org/docs/). Do we need to create a recipe/conda_build_config.yaml
that is just
python_min:
- '3.8'
or do we need to include all possible Python information in it, essentially duplicating all information in .ci_support/linux_64_.yaml
pin_run_as_build:
python:
min_pin: x.x
max_pin: x.x
python:
- 3.12.* *_cpython
python_min:
- '3.8'
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @dopplershift given his participation (and shared concerns on supporting older Pythons) in conda-forge/conda-forge.github.io#2210. Ryan, maybe you have insight here as to how this works?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Put the value you want in a conda-build config in the feedstock and then rerender.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hopefully that works. If not, we can try other things.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks very much @beckermr. That indeed does work. 👍
If I find time this evening I will open and Issue and PR to make things a bit more explicit for people who have only been doing this for a few years like me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Improvements to the docs would certainly be welcome 🙂
Writing good docs seems to be one of the hardest problems in open source. So we welcome all the help we can get 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's hard, and also the conda-forge team has an nearly impossible task of covering a huge landscape of complicated infrastructure (that still amazingly "just works"!).
Given that I'm trying to unbreak some Scikit-HEP related builts that might not happen tonight, but my goal is to open up a PR in the next 24 hours to iterate with you all on. 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, so closer to 96 hours, but: conda-forge/conda-forge.github.io#2370
@conda-forge-admin, please rerender |
…nda-forge-pinning 2024.11.07.16.38.57
python {{ python_min }}
syntax for the python requirements for noarch python recipes.recipe/conda_build_config.yaml
to override the globalpython_min
with uproot'spython_min
of3.8
.Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)