Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uproot-browser v0.7.2 #13

Merged

Conversation

regro-cf-autotick-bot
Copy link
Contributor

@regro-cf-autotick-bot regro-cf-autotick-bot commented Dec 14, 2024

It is very likely that the current package version for this feedstock is out of date.

Checklist before merging this PR:

  • Dependencies have been updated if changed: see upstream
  • Tests have passed
  • Updated license if changed and license_file is packaged

Information about this PR:

  1. Feel free to push to the bot's branch to update this PR if needed.
  2. The bot will almost always only open one PR per version.
  3. The bot will stop issuing PRs if more than 3 version bump PRs generated by the bot are open. If you don't want to package a particular version please close the PR.
  4. If you want these PRs to be merged automatically, make an issue with @conda-forge-admin,please add bot automerge in the title and merge the resulting PR. This command will add our bot automerge feature to your feedstock.
  5. If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase @conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/12331915869 - please use this URL for debugging.

@regro-cf-autotick-bot regro-cf-autotick-bot requested a review from a team as a code owner December 14, 2024 18:06
@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe/meta.yaml:

  • ℹ️ noarch: python recipes should usually follow the syntax in our documentation for specifying the Python version.
    • For the host section of the recipe, you should usually use python {{ python_min }} for the python entry.
    • For the run section of the recipe, you should usually use python >={{ python_min }} for the python entry.
    • For the test.requires section of the recipe, you should usually use python {{ python_min }} for the python entry.
    • If the package requires a newer Python version than the currently supported minimum version on conda-forge, you can override the python_min variable by adding a Jinja2 set statement at the top of your recipe (or using an equivalent context variable for v1 recipes).

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12332001791. Examine the logs at this URL for more detail.

@matthewfeickert matthewfeickert self-assigned this Dec 14, 2024
Copy link
Member

@matthewfeickert matthewfeickert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I should get this to be properly noarch first.

@matthewfeickert
Copy link
Member

@conda-forge-admin, please rerender

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@matthewfeickert matthewfeickert added the automerge Merge the PR when CI passes label Dec 14, 2024
@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Dec 14, 2024

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

  • linter: passed
  • azure: passed

Thus the PR was passing and merged! Have a great day!

@matthewfeickert
Copy link
Member

matthewfeickert commented Dec 14, 2024

E   AttributeError: module 'importlib.resources' has no attribute 'as_file'

scikit-hep-testdata has broken python-requires metadata as importlib.resoruces.as_file was introduced in Python 3.9.

It is picking up scikit-hep-testdata: 0.5.0-pyhd8ed1ab_0 which is before I fixed the meatadata in conda-forge/scikit-hep-testdata-feedstock#68. So scikit-hep-testdata 0.5.0-pyhd8ed1ab_0 needs to get its repodata patched in conda-forge before this can pass. c.f. conda-forge/conda-forge-repodata-patches-feedstock#901 for an example of how to do so.

@matthewfeickert
Copy link
Member

conda-forge/conda-forge-repodata-patches-feedstock#928 has been merged in, so rerunning the CI to see if Anaconda has pulled in the repodata patches yet.

@matthewfeickert
Copy link
Member

@conda-forge-admin, please rerender

@conda-forge-admin conda-forge-admin merged commit 2010805 into conda-forge:main Dec 15, 2024
4 of 5 checks passed
@regro-cf-autotick-bot regro-cf-autotick-bot deleted the 0.7.2_ha465c9 branch December 15, 2024 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge the PR when CI passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants