Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup recipe/cbc.yaml constrains, more platforms #154

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

dbast
Copy link
Member

@dbast dbast commented Jan 7, 2025

This PR does multiple things:

  • Cleans up the not required pinnings in conda_build_config.yaml ... they almost all became default
  • Builds for oldest possible macos x86_64 (older versions result in symbols not found)... for osx arm64 the default macos pinning is fine
  • Removes the recipe/library_licenses folder as that is best practise and as the folder is anyways deleted during builds (see https://github.com/conda-forge/tilt-feedstock/blob/main/recipe/build_library_licenses.sh#L8) and dynamically regenerated
  • Build with node 20 only: there is no sense to build with two node version as the resulting code is frontend code for browsers (according to https://github.com/tilt-dev/tilt/blob/master/web/tsconfig.json#L3) and we do not build backend code linked to a specific node version here
  • Enable linux-{aarch64, ppc64le} builds

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@dbast
Copy link
Member Author

dbast commented Jan 7, 2025

@conda-forge-admin please rerender

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@dbast dbast force-pushed the update branch 3 times, most recently from ba6ac95 to 236ee32 Compare January 8, 2025 13:43
@dbast dbast changed the title Cleanup cbc.yaml constrains Cleanup recipe/cbc.yaml constrains Jan 8, 2025
@dbast dbast changed the title Cleanup recipe/cbc.yaml constrains Cleanup recipe/cbc.yaml constrains, more platforms Jan 8, 2025
@dbast dbast marked this pull request as ready for review January 8, 2025 16:41
@dbast
Copy link
Member Author

dbast commented Jan 8, 2025

@conda-forge/tilt ready for review. thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants