Add liblas and pymcc_lidar #9923

rmsare · 2019-10-20T21:35:16Z

Checklist

License file is packaged (see here for an example)
Source is from official source
Package does not vend other packages
Build number is 0
A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details)
GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there

conda-forge-linter · 2019-10-20T21:35:24Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/pymccrgb) and found it was in an excellent condition.

rmsare · 2019-10-20T21:41:18Z

This package is developed for Linux/OS X, so Windows CI builds will probably fail.

conda-forge-linter · 2019-10-21T16:32:53Z

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/pymccrgb) and found some lint.

Here's what I've got...

For recipes/pymccrgb:

Selectors are suggested to take a <two spaces>#<one space>[<expression>] form. See lines [20]
requirements: build: liblas[channel=auto] must contain a space between the name and the pin, i.e. liblas[channel =auto]

conda-forge-linter · 2019-10-21T16:33:53Z

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/pymccrgb) and found some lint.

Here's what I've got...

For recipes/pymccrgb:

Selectors are suggested to take a <two spaces>#<one space>[<expression>] form. See lines [20]

conda-forge-linter · 2019-10-21T16:39:46Z

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/pymccrgb) and found some lint.

Here's what I've got...

For recipes/pymccrgb:

requirements: build: liblas[channel=auto] must contain a space between the name and the pin, i.e. liblas[channel =auto]

conda-forge-linter · 2019-10-21T17:06:11Z

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/pymccrgb) and found some lint.

Here's what I've got...

For recipes/pymccrgb:

The top level meta keys are in an unexpected order. Expecting ['package', 'source', 'build', 'requirements', 'test', 'about', 'extra'].
The recipe could do with some maintainers listed in the extra/recipe-maintainers section.
The extra section contained an unexpected subsection name. channels is not a valid subsection name.

conda-forge-linter · 2019-10-21T17:18:38Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/pymccrgb) and found it was in an excellent condition.

rmsare · 2019-10-21T17:24:03Z

This package depends on LibLAS, which is only available from the auto channel and so can't be used with conda build. It's a C++ dependency of some Cython code used by this package.

I may try to repackage liblas in conda-forge, which seems to be the only solution unless conda/conda-build#532 is resolved.

Would this be the recommended way to fix this build @conda-forge/help-python?

isuruf · 2019-10-21T17:27:25Z

@conda-forge, we only use packages from defaults and conda-forge. You should add liblas as a conda package to conda-forge.

conda-forge-linter · 2019-10-21T22:34:51Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/liblas, recipes/pymccrgb) and found it was in an excellent condition.

rmsare · 2019-10-21T22:36:26Z

@isuruf I've created a LibLAS recipe for conda-forge.

Can I add it in this PR? Or should I close this and add it in a separate PR, then resubmit?

isuruf · 2019-10-21T22:37:06Z

You can add it to this PR.

rmsare · 2019-10-26T15:04:21Z

The liblas and pymcc_lidar recipes pass, but there are a lot of unsatisfiable dependencies for the main recipe. I'm not sure why this is, as the only new dependencies are pdal/scipy related.

@isuruf Do you have any idea why this is happening, and what might be a good fix?

rmsare · 2019-10-26T15:21:26Z

@gehilley You're listed as a maintainer for pymcc_lidar package. Could you comment here to confirm this?

@hobu I've listed you as a maintainer in the liblas recipe. Could you comment here to confirm this?

gehilley · 2019-10-26T15:25:53Z

Yes

…

On Oct 26, 2019, at 8:21 AM, Robert Sare ***@***.***> wrote: @gehilley <https://github.com/gehilley> You're listed as a maintainer for pymcc_lidar package. Could you comment here to confirm this? @hobu <https://github.com/hobu> I've listed you as a maintainer in the liblas recipe. Could you comment here to confirm this? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#9923?email_source=notifications&email_token=ACBV5VT4TGJNDZHBLXT3HQDQQRN7TA5CNFSM4JCWFYBKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECKKGYI#issuecomment-546612065>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACBV5VRQSHLUITEX7DWBI4TQQRN7TANCNFSM4JCWFYBA>.

hobu · 2019-10-26T16:03:29Z

no problem acting as a liblas maintainer

…

On Oct 26, 2019, at 10:21 AM, Robert Sare ***@***.***> wrote: @gehilley You're listed as a maintainer for pymcc_lidar package. Could you comment here to confirm this? @hobu I've listed you as a maintainer in the liblas recipe. Could you comment here to confirm this? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

recipes/pymcc_lidar/build.sh

Co-Authored-By: Isuru Fernando <[email protected]>

rmsare · 2019-10-31T19:12:35Z

@isuruf Do you have any thoughts on the CI failure here?

The libLAS and pymcc_lidar recipes pass, but a large number of unsatisfiable dependencies arise with pymccrgb.

I have tried pinning one of the problematic dependencies (numpy) which did not help. I also removed fiona, which does require GDAL < 3.0.

conda-forge-linter · 2019-11-14T23:51:48Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/liblas, recipes/pymcc_lidar) and found it was in an excellent condition.

rmsare · 2019-11-14T23:54:30Z

I am going to handle the pymccrgb recipe in a separate PR after I fix it locally.

Sorry for my delay with this, but I've removed the failing recipe. This PR will only add the two other packages which pass CI.

rmsare · 2019-12-12T17:26:56Z

@isuruf I think these recipes are good to go. Do you think this could be merged? Thanks.

stale · 2020-05-10T17:39:39Z

Hi friend!

We really, really, really appreciate that you have taken the time to make a PR on conda-forge/staged-recipes! conda-forge only exists because people like you donate their time to build and maintain conda recipes for use by the community.

In an effort to maintain this repository and increase the signal-to-noise for open PRs, the maintainers of staged-recipes close excessively old PRs after six months. This PR will remain open for another month, and then will be closed.

If you'd like to keep it open, please comment/push and we will be happy to oblige! Note that very old PRs will likely need to be rebased on master so that they can be rebuilt with the most recent CI scripts. If you have any trouble, or we missed reviewing this PR in the first place (sorry!), feel free to ping the team using a special command in a comment on the PR to get the attention of the staged-recipes team.

Cheers and thank you for contributing to this community effort!

hobu · 2020-05-10T17:43:46Z

This is ready to merge. There is also a libLAS release in the works that will catch up a number of maintenance and bug issues that have accumulated over the last 4 years.

stale · 2020-10-07T21:16:40Z

Hi friend!

We really, really, really appreciate that you have taken the time to make a PR on conda-forge/staged-recipes! conda-forge only exists because people like you donate their time to build and maintain conda recipes for use by the community.

In an effort to maintain this repository and increase the signal-to-noise for open PRs, the maintainers of staged-recipes close excessively old PRs after six months. This PR will remain open for another month, and then will be closed.

If you'd like to keep it open, please comment/push and we will be happy to oblige! Note that very old PRs will likely need to be rebased on master so that they can be rebuilt with the most recent CI scripts. If you have any trouble, or we missed reviewing this PR in the first place (sorry!), feel free to ping the team using a special command in a comment on the PR to get the attention of the staged-recipes team.

Cheers and thank you for contributing to this community effort!

stale · 2020-11-07T04:48:37Z

Hi again! About a month ago, we commented on this PR saying it would be closed in another month if it was still inactive. It has been a month and so now it is being closed. Thank you so much for making it in the first place and contributing to the community project that is conda-forge. If you'd like to reopen this PR, please feel free to do so at any time!

Cheers and have a great day!

rmsare added 2 commits October 20, 2019 13:57

Add pymccrgb recipe

897e2a4

Replace build script to install dep from from github

4e1f051

rmsare mentioned this pull request Oct 20, 2019

JOSS review: Improve installation stgl/pymccrgb#17

Open

rmsare added 6 commits October 20, 2019 14:58

Update python in build script

4016cc8

Enable external dep handling

b5884d9

Add compilers/cmake to build requirements

00c6c3b

Add LibLas build dependency as a test

418de10

Try to force channel in meta file

be431a1

Try to force channel in meta file, take 2

015454b

Add space for pin

8ed53be

Try quoting pinned dependency

403b176

Try specifying channel in extra

f5a4d28

Remove extras/channels, keep liblas

848440d

Add liblas recipe

0d32c68

rmsare added 4 commits October 21, 2019 15:45

Update name to libLAS to fix pypi URL

96bcd12

Remove build scripts for liblas

2f34ec9

Use github release link + SHA, which includes LICENSE.txt

e77ce9a

Try to install directly from git

cf36c6a

rmsare added 4 commits October 25, 2019 18:51

Use pin_compat template instead

618ffa1

Update LibLAS info and remove unused deps (i think)

241a6b0

Update LibLAS info and remove unused deps (i think)

55509b4

Bump version after removing fiona dep

e89b2b3

Try to pin numpy in pymccrgb

6cc7b1e

Bump pymccrgb version

fd86c61

isuruf reviewed Oct 26, 2019

View reviewed changes

recipes/pymcc_lidar/build.sh Outdated Show resolved Hide resolved

rmsare and others added 5 commits October 26, 2019 11:40

conda python -> $PYTHON

35abee6

Co-Authored-By: Isuru Fernando <[email protected]>

Try to pin numpy to fix deps

02b080b

Merge branch 'master' of https://github.com/rmsare/staged-recipes

5f0a342

Dont pin numpy

b8484b6

Remove pdal binaries dep, not used

e3fa9ed

Remove recipe for separate PR

1104d93

rmsare changed the title ~~Add pymccrgb~~ Add liblas and pymcc_lidar Nov 14, 2019

stale bot added the stale will be closed in 30 days label May 10, 2020

stale bot removed the stale will be closed in 30 days label May 10, 2020

stale bot added the stale will be closed in 30 days label Oct 7, 2020

stale bot closed this Nov 7, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add liblas and pymcc_lidar #9923

Add liblas and pymcc_lidar #9923

rmsare commented Oct 20, 2019 •

edited

Loading

conda-forge-linter commented Oct 20, 2019

rmsare commented Oct 20, 2019

conda-forge-linter commented Oct 21, 2019

conda-forge-linter commented Oct 21, 2019

conda-forge-linter commented Oct 21, 2019

conda-forge-linter commented Oct 21, 2019

conda-forge-linter commented Oct 21, 2019

rmsare commented Oct 21, 2019 •

edited

Loading

isuruf commented Oct 21, 2019

conda-forge-linter commented Oct 21, 2019

rmsare commented Oct 21, 2019

isuruf commented Oct 21, 2019

rmsare commented Oct 26, 2019 •

edited

Loading

rmsare commented Oct 26, 2019

gehilley commented Oct 26, 2019 via email

hobu commented Oct 26, 2019 via email

rmsare commented Oct 31, 2019

conda-forge-linter commented Nov 14, 2019

rmsare commented Nov 14, 2019

rmsare commented Dec 12, 2019

stale bot commented May 10, 2020

hobu commented May 10, 2020

stale bot commented Oct 7, 2020

stale bot commented Nov 7, 2020

Add liblas and pymcc_lidar #9923

Add liblas and pymcc_lidar #9923

Conversation

rmsare commented Oct 20, 2019 • edited Loading

conda-forge-linter commented Oct 20, 2019

rmsare commented Oct 20, 2019

conda-forge-linter commented Oct 21, 2019

conda-forge-linter commented Oct 21, 2019

conda-forge-linter commented Oct 21, 2019

conda-forge-linter commented Oct 21, 2019

conda-forge-linter commented Oct 21, 2019

rmsare commented Oct 21, 2019 • edited Loading

isuruf commented Oct 21, 2019

conda-forge-linter commented Oct 21, 2019

rmsare commented Oct 21, 2019

isuruf commented Oct 21, 2019

rmsare commented Oct 26, 2019 • edited Loading

rmsare commented Oct 26, 2019

gehilley commented Oct 26, 2019 via email

hobu commented Oct 26, 2019 via email

rmsare commented Oct 31, 2019

conda-forge-linter commented Nov 14, 2019

rmsare commented Nov 14, 2019

rmsare commented Dec 12, 2019

stale bot commented May 10, 2020

hobu commented May 10, 2020

stale bot commented Oct 7, 2020

stale bot commented Nov 7, 2020

rmsare commented Oct 20, 2019 •

edited

Loading

rmsare commented Oct 21, 2019 •

edited

Loading

rmsare commented Oct 26, 2019 •

edited

Loading