-
-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add recipe for Edward #3646
Add recipe for Edward #3646
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
extra: | ||
recipe-maintainers: | ||
- souravsingh | ||
- dustinvtran |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dustinvtran -- are you ok being added as a co-maintainer of the edward
recipe on conda-forge?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep, that's fine.
recipes/edward/meta.yaml
Outdated
|
||
about: | ||
home: http://edwardlib.org | ||
license: Apache |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
license: Apache-2.0
recipes/edward/meta.yaml
Outdated
about: | ||
home: http://edwardlib.org | ||
license: Apache | ||
license_file: LICENSE.txt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The license file isn't packaged in the source distribution due to a missing MANIFEST.in
. Please manually package the license and raise an issue or PR (put url in a comment in the recipe for the issue):
https://conda-forge.org/docs/meta.html#packaging-the-license-manually
recipes/edward/meta.yaml
Outdated
build: | ||
- python | ||
- setuptools | ||
- numpy >=1.7 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think numpy
or six
is required for the build
as the recipe is using --single-version-externally-managed
recipes/edward/meta.yaml
Outdated
about: | ||
home: http://edwardlib.org | ||
license: Apache-2.0 | ||
license_file: '{{ environ["edward"] }}/LICENSE.txt' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The license_file
line is incorrect. It should be:
license_file: '{{ environ["RECIPE_DIR"] }}/LICENSE'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My bad, I thought RECIPE_DIR
is a placeholder where you will replace it with your variable according to your recipe.
@souravsingh I think once you fix the issue that is causing this to fail (which I describe in a different comment), this should be good to merge. |
Somehow I totally missed that you didn't copy the license into the |
Just to put a note here: the build error is the same problem as conda-forge/tensorflow-feedstock#19. The keras recipe can luckily use the theano backend rather than tensorflow for testing on Linux. Edward doesn't have that option. So being able to build and test Edward on conda-forge's infrastructure is probably going to depend on conda-forge building tensorflow from source (conda-forge/tensorflow-feedstock#6). Another issue is that Edward absolutely does depend on tensorflow being installed (e.g. here in |
Hi friend! We really, really, really appreciate that you have taken the time to make a PR on In an effort to maintain this repository and increase the signal-to-noise for open PRs, the maintainers of If you'd like to keep it open, please comment/push and we will be happy to oblige! Note that very old PRs will likely need to be rebased on master so that they can be rebuilt with the most recent CI scripts. If you have any trouble, or we missed reviewing this PR in the first place (sorry!), feel free to ping the team using a special command in a comment on the PR to get the attention of the Cheers and thank you for contributing to this community effort! |
Hi again! About a month ago, we commented on this PR saying it would be closed in another month if it was still inactive. It has been a month and so now it is being closed. Thank you so much for making it in the first place and contributing to the community project that is Cheers and have a great day! |
No description provided.