Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add recipe for Edward #3646

Closed
wants to merge 8 commits into from
Closed

Conversation

souravsingh
Copy link
Contributor

No description provided.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/edward) and found it was in an excellent condition.

extra:
recipe-maintainers:
- souravsingh
- dustinvtran
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dustinvtran -- are you ok being added as a co-maintainer of the edward recipe on conda-forge?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep, that's fine.


about:
home: http://edwardlib.org
license: Apache
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

license: Apache-2.0

about:
home: http://edwardlib.org
license: Apache
license_file: LICENSE.txt
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The license file isn't packaged in the source distribution due to a missing MANIFEST.in. Please manually package the license and raise an issue or PR (put url in a comment in the recipe for the issue):

https://conda-forge.org/docs/meta.html#packaging-the-license-manually

build:
- python
- setuptools
- numpy >=1.7
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think numpy or six is required for the build as the recipe is using --single-version-externally-managed

about:
home: http://edwardlib.org
license: Apache-2.0
license_file: '{{ environ["edward"] }}/LICENSE.txt'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The license_file line is incorrect. It should be:

license_file: '{{ environ["RECIPE_DIR"] }}/LICENSE'

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad, I thought RECIPE_DIR is a placeholder where you will replace it with your variable according to your recipe.

@synapticarbors
Copy link
Member

@souravsingh I think once you fix the issue that is causing this to fail (which I describe in a different comment), this should be good to merge.

@synapticarbors
Copy link
Member

Somehow I totally missed that you didn't copy the license into the recipes/edward directory in this PR. You need to copy it (https://github.com/blei-lab/edward/blob/master/LICENSE.txt) along side of the meta.yaml. I would name it LICENSE.txt to match the upstream repo and then change the line in the meta.yaml to match.

@djsutherland
Copy link
Contributor

djsutherland commented Sep 24, 2017

Just to put a note here: the build error is the same problem as conda-forge/tensorflow-feedstock#19.

The keras recipe can luckily use the theano backend rather than tensorflow for testing on Linux. Edward doesn't have that option. So being able to build and test Edward on conda-forge's infrastructure is probably going to depend on conda-forge building tensorflow from source (conda-forge/tensorflow-feedstock#6).

Another issue is that Edward absolutely does depend on tensorflow being installed (e.g. here in edward.__init__), but doesn't specify an explicit tensorflow dependency because of the gross tensorflow / tensorflow-gpu split. Resolving that so the conda-forge package can properly depend on tensorflow might also need some work.

@stale
Copy link

stale bot commented Feb 13, 2020

Hi friend!

We really, really, really appreciate that you have taken the time to make a PR on conda-forge/staged-recipes! conda-forge only exists because people like you donate their time to build and maintain conda recipes for use by the community.

In an effort to maintain this repository and increase the signal-to-noise for open PRs, the maintainers of staged-recipes close excessively old PRs after six months. This PR will remain open for another month, and then will be closed.

If you'd like to keep it open, please comment/push and we will be happy to oblige! Note that very old PRs will likely need to be rebased on master so that they can be rebuilt with the most recent CI scripts. If you have any trouble, or we missed reviewing this PR in the first place (sorry!), feel free to ping the team using a special command in a comment on the PR to get the attention of the staged-recipes team.

Cheers and thank you for contributing to this community effort!

@stale stale bot added the stale will be closed in 30 days label Feb 13, 2020
@stale
Copy link

stale bot commented Mar 14, 2020

Hi again! About a month ago, we commented on this PR saying it would be closed in another month if it was still inactive. It has been a month and so now it is being closed. Thank you so much for making it in the first place and contributing to the community project that is conda-forge. If you'd like to reopen this PR, please feel free to do so at any time!

Cheers and have a great day!

@stale stale bot closed this Mar 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale will be closed in 30 days
Development

Successfully merging this pull request may close these issues.

5 participants