-
-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add-marvin #28254
base: main
Are you sure you want to change the base?
add-marvin #28254
Conversation
Hi! This is the staged-recipes linter and your PR looks excellent! 🚀 |
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/marvin/meta.yaml:
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipes/marvin/meta.yaml:
|
got Working on that here: #28255 |
|
||
requirements: | ||
host: | ||
- python 3.9 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you need to use the python_min
convention mentioned in https://conda-forge.org/docs/maintainer/knowledge_base/#noarch-python for new noarch
packages. I tend to use the jinja variable {% set python_min = "3.9" %}
explicitly at the top of the recipe.
Checklist
url
) rather than a repo (e.g.git_url
) is used in your recipe (see here for more details).