-
-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add emscripten-activation #27576
base: main
Are you sure you want to change the base?
add emscripten-activation #27576
Conversation
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/emscripten-activation/meta.yaml:
|
@h-vetinari thanks for pushing this forward. I am fine with being a maintainer |
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/emscripten-activation/meta.yaml:
|
CC @isuruf, I assume you'd like to double-check this. Would appreciate your thoughts. |
Thanks! Happy to be a maintainer :) |
# useful variables | ||
export PY_SIDE_LD_FLAGV |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the use of this variable?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DerThorsten, could you comment?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is very likely some leftover from some debugging in the past, should be removable
- emcc ./testfile.c | ||
- node a.out.js |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add an example for a shared library building and use?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair enough. @DerThorsten, do you have a handy example we could use?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to compile a shared library one needs the -s SIDE_MODULE=1
flag.
For cmake, one needs and additonal
set_property(GLOBAL PROPERTY TARGET_SUPPORTS_SHARED_LIBS TRUE)
without that line above cmake will compile static libraries even when a shared library is demanded.
The -s SIDE_MODULE=1
can be passed like:
set(CMAKE_SHARED_LIBRARY_CREATE_C_FLAGS "-s SIDE_MODULE=1")
set(CMAKE_SHARED_LIBRARY_CREATE_CXX_FLAGS "-s SIDE_MODULE=1")
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the question was about actually building some concrete example of a shared library as part of the testing for the activation feedstock, rather than just testfile.c
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clapack and geos are build as shared libraries:
https://github.com/emscripten-forge/recipes/tree/main/recipes/recipes_emscripten/clapack
https://github.com/emscripten-forge/recipes/tree/main/recipes/recipes_emscripten/geos
Thanks a lot for the quick review! 🙏 Will clean up the remnants of emscripten-forge, and I think together with @DerThorsten we'll figure out the other points as well. |
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/emscripten-activation/meta.yaml:
|
We'll need this to be able to use compiler-jinjas (part of the effort for conda-forge/conda-forge.github.io#2244), and more concretely, I'm running into the lack of compiler activation in conda-forge/zlib-feedstock#84.
The (de)activation scripts are taken almost verbatim from https://github.com/emscripten-forge/recipes/blob/main/recipes/recipes/emscripten_emscripten-wasm32/activate.sh (only removed some
BUILD_PREFIX
usage).CC @DerThorsten @wolfv, I added you as maintainers (as in the emscripten-forge recipe already), please let me know if you're (not) OK with that.