Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add hepdata-validator #26279

Merged

Conversation

matthewfeickert
Copy link
Member

@matthewfeickert matthewfeickert commented May 8, 2024

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • [N/A] If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/hepdata-validator) and found some lint.

Here's what I've got...

For recipes/hepdata-validator:

  • The following maintainers have not yet confirmed that they are willing to be listed here: GraemeWatt. Please ask them to comment on this PR if they are.

For recipes/hepdata-validator:

  • License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

Documentation on acceptable licenses can be found here.

@matthewfeickert
Copy link
Member Author

matthewfeickert commented May 8, 2024

@GraemeWatt Can you comment below if you are willing to be a maintainer on this conda-forge recipe (required before a conda-forge maintainer can review this). (c.f. #26279 (comment)) As the package author I want to include you, but I am willing to do the maintenance of hitting "merge" for future releases.

The motivation for this is that hepdata_lib requires hepdata-validator and conda-forge requires that all dependencies of a package be packaged on conda-forge before a package can be distributed on it.

@GraemeWatt
Copy link

@matthewfeickert : thanks for taking care of this! Will you also create a recipe for hepdata_lib (HEPData/hepdata_lib#117)? I don't have experience of conda and I'm not sure I need to be listed as a maintainer if you don't expect me to do any maintenance, but I'm willing to be listed if you think it's a good idea.

@matthewfeickert
Copy link
Member Author

Will you also create a recipe for hepdata_lib (HEPData/hepdata_lib#117)?

Yes. That was my original intent, but I realized that I needed hepdata-validator first.

I'm not sure I need to be listed as a maintainer if you don't expect me to do any maintenance, but I'm willing to be listed if you think it's a good idea.

I in general like to have at least 2 people listed as maintainers and for assurance reasons I also like to have a package author/owner be one of them. So thanks!

* c.f. https://github.com/HEPData/hepdata-validator
* Recipe generated with grayskull via 'grayskull pypi hepdata-validator'
  and then edited to add additional information.
@matthewfeickert matthewfeickert force-pushed the feat/add-hepdata-validator branch from d67fd52 to 52dc196 Compare May 8, 2024 16:44
@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/hepdata-validator) and found it was in an excellent condition.

@matthewfeickert
Copy link
Member Author

@conda-forge/help-python, ready for review!

@ocefpaf ocefpaf merged commit 0ba914c into conda-forge:main May 8, 2024
5 checks passed
@matthewfeickert matthewfeickert deleted the feat/add-hepdata-validator branch May 8, 2024 17:42
@matthewfeickert
Copy link
Member Author

Will you also create a recipe for hepdata_lib (HEPData/hepdata_lib#117)?

Yes. That was my original intent, but I realized that I needed hepdata-validator first.

c.f. PR #26293

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants