-
-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add recipes for lsst-sphgeom
and lsst-versions
#24930
Conversation
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/lsst-sphgeom:
For recipes/lsst-sphgeom:
Documentation on acceptable licenses can be found here. |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/lsst-sphgeom:
|
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/lsst-sphgeom:
|
eef1152
to
129e409
Compare
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
One thing I'd love to do with a conda distribution of sphgeom would be to build a standalone C++ library, as we do when building sphgeom as part of the LSST Science Pipelines. That's not what's done with |
So we don't forget: let's add |
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/lsst-sphgeom:
For recipes/lsst-versions:
|
Hi @erykoff @timj @TallJimbo, could you please leave a comment in this pull request to confirm you as maintainers? |
I am happy to be listed as a maintainer on these. |
I don't think it will build correctly until we push the new version tomorrow evening with the new license. |
I am happy to be listed as a maintainer on these. |
I've merged lsst/sphgeom#63 so the release on PyPI tomorrow night should have the right license for you. |
Thank you @timj for making it so quick, appreciate it! |
I'm happy to be a maintainer. |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
cfa28dd
to
d5767e5
Compare
@conda-forge-admin please restart ci |
7e45b8b
to
7b17515
Compare
@conda-forge/help-python-c @beckermr, ready for review! Additionally tagging @carterbox, as this seems to be another case where issue conda/conda-build#5136 was reproduced. |
LGTM! One word of warning. We've found with, e.g. the old astropy build tooling, that having custom pip integrations needed in host can cause painful maintenance issues later. Otherwise, please backout the build script changes (I understand you added them to make sure things worked right - no problem at all!) and we can merge! |
7b17515
to
bf5644e
Compare
Thank you @beckermr, the changes were reverted! |
Checklist
url
) rather than a repo (e.g.git_url
) is used in your recipe (see here for more details).