Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add recipes for lsst-sphgeom and lsst-versions #24930

Merged
merged 10 commits into from
Jan 12, 2024

Conversation

camposandro
Copy link
Contributor

@camposandro camposandro commented Jan 4, 2024

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/lsst-sphgeom, recipes/lsst-versions) and found some lint.

Here's what I've got...

For recipes/lsst-sphgeom:

  • The home item is expected in the about section.

For recipes/lsst-sphgeom:

  • License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

Documentation on acceptable licenses can be found here.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/lsst-sphgeom, recipes/lsst-versions) and found it was in an excellent condition.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/lsst-sphgeom, recipes/lsst-versions) and found some lint.

Here's what I've got...

For recipes/lsst-sphgeom:

  • noarch: python recipes are required to have a lower bound on the python version. Typically this means putting python >=3.6 in both host and run but you should check upstream for the package's Python compatibility.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/lsst-sphgeom, recipes/lsst-versions) and found some lint.

Here's what I've got...

For recipes/lsst-sphgeom:

  • requirements: host: python >= 3.8 should not contain a space between relational operator and the version, i.e. python >=3.8
  • requirements: run: python >= 3.8 should not contain a space between relational operator and the version, i.e. python >=3.8
  • Non noarch packages should have python requirement without any version constraints.
  • Non noarch packages should have python requirement without any version constraints.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/lsst-sphgeom, recipes/lsst-versions) and found it was in an excellent condition.

@camposandro camposandro marked this pull request as ready for review January 8, 2024 16:01
@TallJimbo
Copy link

One thing I'd love to do with a conda distribution of sphgeom would be to build a standalone C++ library, as we do when building sphgeom as part of the LSST Science Pipelines. That's not what's done with pip (due to limitations in setuptools, as I understand it), so I'm sure it'd be more work, and I don't think it's urgent. But we'll need to do that if we ever want to use conda to distribute any other downstream LSST code that depends on it that isn't pure Python.

recipes/lsst-sphgeom/meta.yaml Outdated Show resolved Hide resolved
@mjuric
Copy link
Contributor

mjuric commented Jan 9, 2024

So we don't forget: let's add erykoff, timj, TallJimbo to maintainers in meta.yaml of both lsst-sphgeom and lsst-versions.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/lsst-sphgeom, recipes/lsst-versions) and found some lint.

Here's what I've got...

For recipes/lsst-sphgeom:

  • The following maintainers have not yet confirmed that they are willing to be listed here: erykoff. Please ask them to comment on this PR if they are.

For recipes/lsst-versions:

  • The following maintainers have not yet confirmed that they are willing to be listed here: erykoff. Please ask them to comment on this PR if they are.

@camposandro
Copy link
Contributor Author

camposandro commented Jan 9, 2024

Hi @erykoff @timj @TallJimbo, could you please leave a comment in this pull request to confirm you as maintainers?

@erykoff
Copy link
Contributor

erykoff commented Jan 9, 2024

I am happy to be listed as a maintainer on these.

@erykoff
Copy link
Contributor

erykoff commented Jan 9, 2024

I don't think it will build correctly until we push the new version tomorrow evening with the new license.

@timj
Copy link
Contributor

timj commented Jan 9, 2024

I am happy to be listed as a maintainer on these.

@timj
Copy link
Contributor

timj commented Jan 9, 2024

I've merged lsst/sphgeom#63 so the release on PyPI tomorrow night should have the right license for you.

@camposandro
Copy link
Contributor Author

Thank you @timj for making it so quick, appreciate it!

@TallJimbo
Copy link

I'm happy to be a maintainer.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/lsst-sphgeom, recipes/lsst-versions) and found it was in an excellent condition.

@erykoff
Copy link
Contributor

erykoff commented Jan 12, 2024

@conda-forge-admin please restart ci

@camposandro
Copy link
Contributor Author

@conda-forge/help-python-c @beckermr, ready for review!

Additionally tagging @carterbox, as this seems to be another case where issue conda/conda-build#5136 was reproduced.

@beckermr
Copy link
Member

LGTM!

One word of warning. We've found with, e.g. the old astropy build tooling, that having custom pip integrations needed in host can cause painful maintenance issues later.

Otherwise, please backout the build script changes (I understand you added them to make sure things worked right - no problem at all!) and we can merge!

@camposandro
Copy link
Contributor Author

Thank you @beckermr, the changes were reverted!

@beckermr beckermr merged commit 64b5800 into conda-forge:main Jan 12, 2024
1 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

6 participants