-
-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add libqdldl recipe #15140
Add libqdldl recipe #15140
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@conda-forge/help-c-cpp The PR is now ready for review. |
Thanks for the ping, I'd be willing to join! :) |
Great! And thanks for the comment, I did not noticed that a Windows CI test was failing, it should be fixed now. |
Sorry for being a bit premature before, but now the build passes correctly and the recipe is ready for review. |
recipes/libqdldl/build.sh
Outdated
-DCMAKE_PREFIX_PATH=$PREFIX \ | ||
-DCMAKE_INSTALL_PREFIX=$PREFIX \ | ||
-DCMAKE_INSTALL_LIBDIR=lib \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not needed, part of CMAKE_ARGS
.
-DCMAKE_PREFIX_PATH=$PREFIX \ | |
-DCMAKE_INSTALL_PREFIX=$PREFIX \ | |
-DCMAKE_INSTALL_LIBDIR=lib \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, I was not aware of it. Do you have a pointer on where CMAKE_ARGS
is defined so that I can check with arguments are already there?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done in bc99b66 .
This packages the
qdldl
library for C as its own package, to be used as a dependency of libosqp (see conda-forge/libosqp-feedstock#3) and libscs (conda-forge/scs-feedstock#18) differently from osqp and scs, in the qdldl case the corresponding python package is called qdldl-python (https://github.com/conda-forge/qdldl-python-feedstock) so we could have called this recipe directlyqdldl
, but I prefer to remain coherent with thelibosqp
and the futurelibscs
packages names. If there is any other preference, I would be happy to switch the recipe name to qdldl.@h-vetinari I added you as a maintainer given that you are already a mantainer of osqp and scs, let me know if this is ok for you.
I included a patch to permit to only build a shared library and to support building shared libraries on Windows. I did not submit this upstream for now as there are already PR with similar goals but different and slightly more complex (osqp/qdldl#38 and osqp/qdldl#36), if those end being accepted upstream and integrated in the release, I will remove this patch and use the options provided in those PRs.
I did not assumed any kind of ABI compatibility policy on patch releases, as none is documented and the system project osqp had API/ABI breakage in minor releases in the past.
Checklist
url
) rather than a repo (e.g.git_url
) is used in your recipe (see here for more details).