Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add libqdldl recipe #15140

Merged
merged 9 commits into from
Jun 7, 2021
Merged

Add libqdldl recipe #15140

merged 9 commits into from
Jun 7, 2021

Conversation

traversaro
Copy link
Contributor

@traversaro traversaro commented Jun 2, 2021

This packages the qdldl library for C as its own package, to be used as a dependency of libosqp (see conda-forge/libosqp-feedstock#3) and libscs (conda-forge/scs-feedstock#18) differently from osqp and scs, in the qdldl case the corresponding python package is called qdldl-python (https://github.com/conda-forge/qdldl-python-feedstock) so we could have called this recipe directly qdldl, but I prefer to remain coherent with the libosqp and the future libscs packages names. If there is any other preference, I would be happy to switch the recipe name to qdldl.

@h-vetinari I added you as a maintainer given that you are already a mantainer of osqp and scs, let me know if this is ok for you.

I included a patch to permit to only build a shared library and to support building shared libraries on Windows. I did not submit this upstream for now as there are already PR with similar goals but different and slightly more complex (osqp/qdldl#38 and osqp/qdldl#36), if those end being accepted upstream and integrated in the release, I will remove this patch and use the options provided in those PRs.

I did not assumed any kind of ABI compatibility policy on patch releases, as none is documented and the system project osqp had API/ABI breakage in minor releases in the past.

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/libqdldl) and found it was in an excellent condition.

@traversaro traversaro changed the title [WIP] Add libqdldl recipe Add libqdldl recipe Jun 2, 2021
@traversaro
Copy link
Contributor Author

@conda-forge/help-c-cpp The PR is now ready for review.

@h-vetinari
Copy link
Member

Thanks for the ping, I'd be willing to join! :)

@traversaro
Copy link
Contributor Author

Thanks for the ping, I'd be willing to join! :)

Great! And thanks for the comment, I did not noticed that a Windows CI test was failing, it should be fixed now.

@traversaro
Copy link
Contributor Author

@conda-forge/help-c-cpp The PR is now ready for review.

Sorry for being a bit premature before, but now the build passes correctly and the recipe is ready for review.

Comment on lines 8 to 10
-DCMAKE_PREFIX_PATH=$PREFIX \
-DCMAKE_INSTALL_PREFIX=$PREFIX \
-DCMAKE_INSTALL_LIBDIR=lib \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not needed, part of CMAKE_ARGS.

Suggested change
-DCMAKE_PREFIX_PATH=$PREFIX \
-DCMAKE_INSTALL_PREFIX=$PREFIX \
-DCMAKE_INSTALL_LIBDIR=lib \

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, I was not aware of it. Do you have a pointer on where CMAKE_ARGS is defined so that I can check with arguments are already there?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in bc99b66 .

@xhochy xhochy merged commit 16e3a6d into conda-forge:master Jun 7, 2021
@traversaro traversaro mentioned this pull request Jun 16, 2021
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants