-
-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add xyzspaces #12501
Add xyzspaces #12501
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Since I am posting this PR I am also willing to be listed here... ;) |
I see in the Azure pipeline logs that |
recipes/xyzspaces/meta.yaml
Outdated
|
||
build: | ||
number: 0 | ||
skip: True # [py<36] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
conda-forge isn't building for pytho<3.6, so you can remove the skip and use noarch: python
:
https://conda-forge.org/docs/maintainer/knowledge_base.html#noarch-python
you can always add the version restrictions under requirements
(i.e change python
to python >=3.6
under host
and run
)
- python | ||
- pip | ||
run: | ||
- python |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to add everything in the setup.py
's install_requires
, which looks to be read out of:
https://github.com/heremaps/xyz-spaces-python/blob/master/requirements.txt
I'm guessing the issue with fiona
not being on the list, but being required is that it is a dependency of one of the listed dependencies, so it gets picked up. Just a guess though
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/xyzspaces:
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/xyzspaces:
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
I don't seem to put the pip-only dependencies like "turfpy" and "geobuf" at the right place. When trying to run Maybe this is still relevant, which seems to suggest I cannot list pip-only dependencies in a recipe? conda/conda-build#548 and conda-forge/conda-forge.github.io#28. |
@deeplook - we don't really want any pip-only dependencies. We'll need to open separate pull requests for |
@synapticarbors While I can imagine the reasoning (stability, etc.) behind not wanting to support plain pip packages (which is somewhat ironic, as pip is still needed, I believe), I have failed to see a bold argument like this made on https://conda-forge.org/docs/index.html. I think this could help people spend more time on relevant things (like convincing other maintainers to publish their packages on conda-forge). What do you think? |
I see https://github.com/conda-forge/turfpy-feedstock and https://github.com/conda-forge/geobuf-feedstock now. Awesome, thanks! |
@deeplook -- I restarted the build in this PR and it looks like linux is now passing. Just waiting on the others. |
@deeplook -- can you confirm that the other co-maintainers have agreed to be listed? Otherwise they should comment here saying they are. |
@synapticarbors I confirm. |
@synapticarbors Anything else I need to do? Otherwise this is ready for review. |
Thanks! |
@synapticarbors BTW, the description field on https://anaconda.org/conda-forge/xyzspaces is empty despite the description given in the |
No packages on conda-forge have that populated (e.g https://anaconda.org/conda-forge/numpy). The description shows up in https://github.com/conda-forge/xyzspaces-feedstock#about-xyzspaces |
Checklist
url
) rather than a repo (e.g.git_url
) is used in your recipe (see here for more details)