Rebuild for CUDA 12 w/arch + Windows support #92
Conversation
The transition to CUDA 12 SDK includes new packages for all CUDA libraries and build tools. Notably, the cudatoolkit package no longer exists, and packages should depend directly on the specific CUDA libraries (libcublas, libcusolver, etc) as needed. For an in-depth overview of the changes and to report problems [see this issue]( conda-forge/conda-forge.github.io#1963 ). Please feel free to raise any issues encountered there. Thank you! 🙏
…nda-forge-pinning 2023.12.02.04.59.50
regro-cf-autotick-bot
requested review from
cbourjau,
janjagusch,
jtilly and
xhochy
as code owners
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
| cudnn: # [linux64] | ||
| - undefined # [linux64] | ||
| cuda_compiler_version: # [linux64] | ||
| - None # [linux64] | ||
| docker_image: # [linux64] | ||
| - quay.io/condaforge/linux-anvil-cos7-x86_64 # [linux64] | ||
| cdt_name: # [linux64] | ||
| - cos7 # [linux64] |
There was a problem hiding this comment.
Appears the bot is adding this. Following up in upstream issue ( regro/cf-scripts#1981 )
Though don't think we need this logic. Would propose dropping and re-rendering
| cudnn: # [linux64] | |
| - undefined # [linux64] | |
| cuda_compiler_version: # [linux64] | |
| - None # [linux64] | |
| docker_image: # [linux64] | |
| - quay.io/condaforge/linux-anvil-cos7-x86_64 # [linux64] | |
| cdt_name: # [linux64] | |
| - cos7 # [linux64] |
There was a problem hiding this comment.
This behavior changed in the bot with PR ( regro/cf-scripts#1982 )
| @@ -19,7 +19,7 @@ source: | |||
|
|
|||
|
|
|||
| build: | |||
| number: 1 | |||
| number: 2 | |||
| # Since 1.11, power9 seems to be required. | |||
| skip: true # [ppc64le] | |||
| skip: true # [cuda_compiler_version == "10.2" or cuda_compiler_version == "11.0" or cuda_compiler_version == "11.1"] | |||
There was a problem hiding this comment.
As conda-forge is on CUDA 11.2+ ( conda-forge/conda-forge-pinning-feedstock#1708 ), these skips are redundant and can be dropped
| skip: true # [cuda_compiler_version == "10.2" or cuda_compiler_version == "11.0" or cuda_compiler_version == "11.1"] |
|
Also if the goal of this line is to skip all Windows CUDA builds onnxruntime-feedstock/recipe/meta.yaml Line 26 in 2510433 Maybe we can change it to skip: true # [win and cuda_compiler != "None"]This would more generally skip CUDA builds as opposed to checking specific versions |
|
Going to ask the bot to rerun as there have been some changes in the bot that should simplify this |
|
Due to the |
|
Superseded by PR ( #95 ) |
This PR has been triggered in an effort to update cuda120.
Notes and instructions for merging this PR:
Please note that if you close this PR we presume that the feedstock has been rebuilt, so if you are going to perform the rebuild yourself don't close this PR until the your rebuild has been merged.
Here are some more details about this specific migrator:
If this PR was opened in error or needs to be updated please add the
bot-rerunlabel to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase@conda-forge-admin, please rerun botin a PR comment to have theconda-forge-adminadd it for you.This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/7067998975, please use this URL for debugging.