Use global pinnings in build matrix (same elements as before) #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipe/meta.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12193730264. Examine the logs at this URL for more detail. |
…onda-forge-pinning 2024.12.05.23.59.20
Drop the bulk of `conda_build_config.yaml` in favor of using the values
in the global pinnings. This cuts down on duplication of this content
and thus makes it easier to pull in the latest changes (like recent
Docker image and CDT changes).
Also adapt the recipe slightly so that we only pick out the `nvcc`
configuration. Plus make sure conda-smithy recognizes this is a CUDA
using recipe even though it does not use `compiler("cuda")` in the
build. Do this by adapting the `skip` to check `compiler("cuda")`
matches `nvcc*`.
jakirkham
requested review from
dillon-cullinan,
isuruf,
jaimergp,
jakirkham,
kkraus14,
leofang,
mike-wendt,
raydouglass and
a team
as code owners
|
@conda-forge-admin , please re-render |
…onda-forge-pinning 2024.12.05.23.59.20
jakirkham
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleans up how the build matrix is configured to leverage the global pinnings by doing the following...
conda_build_config.yamlskipto select outnvcc& re-render correctlyPackages are unchanged. So
build/numberstays the sameFixes #113