-
-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove setuptools constraint #106
Remove setuptools constraint #106
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Why would tests need patching? Everything should be working again after the rollback in setuptools 65.0.2 or 65.1. I could be wrong, of course, but I'd expect it to work. |
There are some tests that ensure that Numba import doesn't produce any warnings. I was concerned that the deprecation warning that suggests using setuptools < 60 might be produced by NumPy and cause this test to fail. Though, looking at the set of tests that run, we don't have a test with NumPy 1.23 in the list of configurations, so maybe we won't run into this issue 🤞 |
Shouldn't we have a test with NumPy 1.23? :D (not in this PR, but sounds like something that needs to be added then) |
Yes, we should test with NumPy 1.23 - I was thinking of following up with that later once the dust has settled here. |
cc @xhochy |
Seems that the PPC builds are a bit close to the time limit and some of them timed out for this PR - do we just re-run tests when this happens? |
Yep have restarted those jobs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, anything left?
Thanks all! 🙏 Just a note, we are still seeing |
Based on and closes #105 with the setuptools constraint removed from setup.py in an attempt to make
pip check
succeed. I expect a further patch to some tests may be required.Closes #104 too.
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)