Updated to 6.4.4 -- added windows build #31

scharlton2 · 2024-02-16T19:57:31Z

Checklist

Used a personal fork of the feedstock to propose changes
Bumped the build number (if the version is unchanged)
Reset the build number to 0 (if the version changed)
Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
Ensured the license file is being packaged.

conda-forge-webservices · 2024-02-16T19:57:39Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

github-actions · 2024-02-16T19:59:12Z

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/modflow6-feedstock/actions/runs/7935584201.

recipe/meta.yaml

jdhughes-usgs · 2024-02-16T21:45:29Z

@scharlton2 It does not look like the windows build is starting on Azure

jdhughes-usgs

Work be good to add yourself (@scharlton2) as a maintainer.

jdhughes-usgs · 2024-02-16T22:07:08Z

recipe/meta.yaml


 package:
  name: {{ name|lower }}
  version: {{ version }}

 source:
  url: https://github.com/MODFLOW-USGS/modflow6/releases/download/{{ version }}/mf{{ version }}_linux.zip
-  sha256: 8dcd832f33f992a9935c473fc3d695aac9250d4b34c944e54a7d44122df8e876
+  sha256: a737521126efc3295b818acc951a745d7b914446836c7931b0b52998f3934e2d

 build:
  number: 0


Update the build number from 0 -> 1.

Sorry for not merging the previous PR before now.

scharlton2 · 2024-02-16T23:01:06Z

@conda-forge-admin, please rerender

…nda-forge-pinning 2024.02.16.20.35.25

@conda-forge-admin

@conda-forge-admin, please rerender

conda-forge-webservices · 2024-02-21T21:14:22Z

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

Selectors are suggested to take a <two spaces>#<one space>[<expression>] form. See lines [16, 17]

recipe/meta.yaml

mwtoews · 2024-02-21T23:32:41Z

I've just checked compiling the latest modflow6 code locally on a Windows computer with m2w64-gcc-fortran, and I see the same error on CI:

ninja: Entering directory `D:/src/modflow6/_build'
[13/448] Compiling Fortran object src/libmf6core.a.p/Utilities_CharString.f90.obj
FAILED: src/libmf6core.a.p/Utilities_CharString.f90.obj src/libmf6core.a.p/characterstringmodule.mod
"gfortran" "-Isrc\libmf6core.a.p" "-Isrc" "-I..\src" "-Isrc\libmf6_external.a.p" "-fdiagnostics-color=always" "-D_FILE_OFFSET_BITS=64" "-Wall" "-std=f2008" "-O0" "-g" "-fall-intrinsics" "-pedantic" "-cpp" "-Wcharacter-truncation" "-Wno-unused-dummy-argument" "-Wno-intrinsic-shadow" "-Wno-maybe-uninitialized" "-Wno-uninitialized" "-fcheck=all" "-ffpe-trap=overflow,zero,invalid" "-D_WIN32" "-Jsrc\libmf6core.a.p" -o src/libmf6core.a.p/Utilities_CharString.f90.obj "-c" ../src/Utilities/CharString.f90
f951.exe: internal compiler error: Segmentation fault
libbacktrace could not find executable to open
Please submit a full bug report,
with preprocessed source if appropriate.
See <https://sourceforge.net/projects/msys2> for instructions.
[14/448] Compiling Fortran object src/libmf6core.a.p/Utilities_kind.f90.obj
ninja: build stopped: subcommand failed.

or simply with running a basic gfortran command:

D:\src\modflow6>gfortran -c src\Utilities\CharString.f90
f951.exe: internal compiler error: Segmentation fault
libbacktrace could not find executable to open
Please submit a full bug report,
with preprocessed source if appropriate.
See <https://sourceforge.net/projects/msys2> for instructions.

This is a compiler bug. It might be possible to investigate and "fix" modflow6 to work with this old gfortran version for Windows.

Unfortunately, I'm not yet aware of a more modern Fortran version for Windows in conda-forge. The only other Windows compiler is flang, and I've not had much success using it.

conda-forge-webservices · 2024-02-21T23:42:05Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

mwtoews · 2024-02-21T23:50:34Z

@conda-forge-admin, please rerender

…nda-forge-pinning 2024.02.21.20.22.11

scharlton2 · 2024-02-22T00:04:47Z

Sorry, didn't see your rerender

mwtoews · 2024-02-22T00:13:51Z

Doesn't seem to matter, it's the same old gfortran compiler bug. However I can confirm that at local build can be made by using the newer Fortran compilers:

mamba install conda-forge/label/m2w64-experimental::mingw-w64-ucrt-x86_64-gcc-fortran

this installs a modern gfortran (gcc 13.2.0) which works nicely with modflow6.

The challenge, which I see you've already made an attempt at, is to get this into the recipe...

scharlton2 · 2024-02-22T00:21:23Z

I think the main problem is this:
https://dev.azure.com/conda-forge/feedstock-builds/_build/results?buildId=881853&view=logs&j=a70f640f-cc53-5cd3-6cdc-236a1aa90802&t=6119ccbe-9301-594f-7c27-f792b80a7fcc&l=842

it's just too old (5.3.0 on windows vs 12.3.0 on linux/osx)

scharlton2 · 2024-02-22T00:36:39Z

Sorry again, just saw your latest comment

This worked on my local windows machine:

❯ micromamba env export --from-history

name: test2
channels:
- conda-forge
- conda-forge/label/m2w64-experimental
dependencies:
- conda-forge::meson
- conda-forge/label/m2w64-experimental::mingw-w64-ucrt-x86_64-gcc-fortran

But I couldn't figure out how to add the conda-forge/label/m2w64-experimental to the meta.yaml file

mwtoews · 2024-02-22T00:41:04Z

@conda-forge-admin, please rerender

…nda-forge-pinning 2024.02.21.20.22.11

mwtoews · 2024-02-22T00:43:20Z

Enabling the conda-forge/label/m2w64-experimental channel would be a good solution. I'm trying again, but I'm not sure if it's possible, see conda/conda-build#532

scharlton2 · 2024-02-22T01:39:21Z

We might be able to use recipe/conda_build_config.yaml to override channel resolution see .ci_support/README and recipe/conda_build_config

scharlton2 · 2024-02-22T01:40:38Z

@conda-forge-admin, please rerender

…nda-forge-pinning 2024.02.21.20.22.11

github-actions · 2024-02-22T16:56:14Z

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/modflow6-feedstock/actions/runs/8008118793.

github-actions · 2024-02-22T16:56:19Z

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/modflow6-feedstock/actions/runs/8008118319.

github-actions · 2024-02-22T16:56:29Z

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/modflow6-feedstock/actions/runs/8008120092.

github-actions · 2024-02-22T16:56:31Z

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/modflow6-feedstock/actions/runs/8008118952.

ie Needed DSO Library/bin/api-ms-win-crt-environment-l1-1-0.dll ... Needed DSO Library/bin/api-ms-win-crt-time-l1-1-0.dll

…-libgfortran to reqs/run deps: mingw-w64-ucrt-x86_64-libwinpthread-git mingw-w64-ucrt-x86_64-gcc-libs

scharlton2 · 2024-02-23T00:39:57Z

@jdhughes-usgs, @mwtoews, @scopatz, and @Hofer-Julian if there are no objections, I think this PR is ready to go.

…nda-forge-pinning 2024.02.22.20.36.14

mwtoews · 2024-02-23T02:28:14Z

I'm doing a few things locally. With this PR, I'm able to use a minimal environment with conda-build and conda-verify, then run:

conda build path/to/recipe -c conda-forge/label/m2w64-experimental

(the -c channel arg is needed, otherwise an error is raised: "mingw-w64-ucrt-x86_64-gcc-fortran does not exist")

The local build and test appear to be successful. However,

mamba install --dry-run modflow6

has error:

Could not solve for environment specs
The following packages are incompatible
├─ m2-conda-epoch is installable and it requires
│  └─ msys2-conda-epoch <0.0a0 , which can be installed;
└─ modflow6 is not installable because it requires
   └─ m2w64-gcc-libs, which requires
      └─ msys2-conda-epoch 20160418 , which conflicts with any installable versions previously reported.

It might not be possible to install this package without adding/modifying channels.

scharlton2 · 2024-02-23T03:53:41Z

Thanks @mwtoews. I'll try building locally tomorrow.

scharlton2 · 2024-02-23T18:51:51Z

Sorry, just re-read your comment please ignore.

@mwtoews How did you build locally? Here's what I tried:

micromamba create -n modflow-local-build
micromamba activate modflow-local-build
micromamba install conda-build conda-verify
micromamba activate modflow-local-build
git clone [email protected]:scharlton2/modflow6-feedstock.git
cd modflow6-feedstock
git switch main-with-windows-build
python .\build-locally.py

choosing 6. win_64_ config yields:

selected win_64_
Traceback (most recent call last):
  File "C:\Users\charlton\source\repos\feedstocks\modflow6-feedstock\build-locally.py", line 106, in <module>
    main()
  File "C:\Users\charlton\source\repos\feedstocks\modflow6-feedstock\build-locally.py", line 87, in main
    verify_config(ns)
  File "C:\Users\charlton\source\repos\feedstocks\modflow6-feedstock\build-locally.py", line 61, in verify_config
    raise ValueError(
ValueError: only Linux/macOS configs currently supported, got win_64_

scharlton2 · 2024-04-30T15:58:35Z

Replaced by #33

Updated to 6.4.4 -- added windows build

5cbf36a

scharlton2 requested review from Hofer-Julian, jdhughes-usgs, mwtoews and scopatz as code owners February 16, 2024 19:57

mwtoews reviewed Feb 16, 2024

View reviewed changes

recipe/meta.yaml Show resolved Hide resolved

Removed skip

36b0678

jdhughes-usgs reviewed Feb 16, 2024

View reviewed changes

scharlton2 added 2 commits February 16, 2024 15:41

Merge branch 'conda-forge:main' into main-with-windows-build

518282b

Updated azure-pipelines.yml along with build number and added maintainer

07e9b99

conda-forge-webservices[bot] and others added 3 commits February 16, 2024 23:02

MNT: Re-rendered with conda-build 24.1.2, conda-smithy 3.30.4, and co…

d659ce8

…nda-forge-pinning 2024.02.16.20.35.25

Try just fortran compiler

aa1e900

@conda-forge-admin, please rerender

Give it a try

24e507e

mwtoews reviewed Feb 21, 2024

View reviewed changes

recipe/meta.yaml Outdated Show resolved Hide resolved

Try original settings

c5aa15e

conda-forge-webservices[bot] and others added 2 commits February 21, 2024 23:52

MNT: Re-rendered with conda-build 24.1.2, conda-smithy 3.30.4, and co…

6e075f2

…nda-forge-pinning 2024.02.21.20.22.11

Try using conda-forge/libbezier-feedstock requirements

9e93e5e

Try using experimental channel again

8b9560a

MNT: Re-rendered with conda-build 24.1.2, conda-smithy 3.30.4, and co…

fc92499

…nda-forge-pinning 2024.02.21.20.22.11

Try adding channel via conda_build_config.yaml

6fa0434

MNT: Re-rendered with conda-build 24.1.2, conda-smithy 3.30.4, and co…

e7a4339

…nda-forge-pinning 2024.02.21.20.22.11

scharlton2 added 4 commits February 22, 2024 11:17

Add ucrt to reqs/run

12560b9

ie Needed DSO Library/bin/api-ms-win-crt-environment-l1-1-0.dll ... Needed DSO Library/bin/api-ms-win-crt-time-l1-1-0.dll

Added windows selector for ucrt

46e9e76

Added conda-forge/label/m2w64-experimental::mingw-w64-ucrt-x86_64-gcc…

c86fafa

…-libgfortran to reqs/run deps: mingw-w64-ucrt-x86_64-libwinpthread-git mingw-w64-ucrt-x86_64-gcc-libs

Explicitly added mingw-w64-ucrt-x86_64-gcc-libs

fc98511

MNT: Re-rendered with conda-build 24.1.2, conda-smithy 3.31.0, and co…

f1fe718

…nda-forge-pinning 2024.02.22.20.36.14

scharlton2 closed this Apr 30, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Updated to 6.4.4 -- added windows build #31

Updated to 6.4.4 -- added windows build #31

scharlton2 commented Feb 16, 2024 •

edited

Loading

conda-forge-webservices bot commented Feb 16, 2024

github-actions bot commented Feb 16, 2024

jdhughes-usgs commented Feb 16, 2024

jdhughes-usgs left a comment

jdhughes-usgs Feb 16, 2024

scharlton2 Feb 16, 2024

scharlton2 commented Feb 16, 2024

conda-forge-webservices bot commented Feb 21, 2024

mwtoews commented Feb 21, 2024 •

edited

Loading

conda-forge-webservices bot commented Feb 21, 2024

mwtoews commented Feb 21, 2024

scharlton2 commented Feb 22, 2024

mwtoews commented Feb 22, 2024

scharlton2 commented Feb 22, 2024

scharlton2 commented Feb 22, 2024 •

edited

Loading

mwtoews commented Feb 22, 2024

mwtoews commented Feb 22, 2024

scharlton2 commented Feb 22, 2024

scharlton2 commented Feb 22, 2024

github-actions bot commented Feb 22, 2024

github-actions bot commented Feb 22, 2024

github-actions bot commented Feb 22, 2024

github-actions bot commented Feb 22, 2024

scharlton2 commented Feb 23, 2024

mwtoews commented Feb 23, 2024

scharlton2 commented Feb 23, 2024

scharlton2 commented Feb 23, 2024 •

edited

Loading

scharlton2 commented Apr 30, 2024

Updated to 6.4.4 -- added windows build #31

Updated to 6.4.4 -- added windows build #31

Conversation

scharlton2 commented Feb 16, 2024 • edited Loading

conda-forge-webservices bot commented Feb 16, 2024

github-actions bot commented Feb 16, 2024

jdhughes-usgs commented Feb 16, 2024

jdhughes-usgs left a comment

Choose a reason for hiding this comment

jdhughes-usgs Feb 16, 2024

Choose a reason for hiding this comment

scharlton2 Feb 16, 2024

Choose a reason for hiding this comment

scharlton2 commented Feb 16, 2024

conda-forge-webservices bot commented Feb 21, 2024

mwtoews commented Feb 21, 2024 • edited Loading

conda-forge-webservices bot commented Feb 21, 2024

mwtoews commented Feb 21, 2024

scharlton2 commented Feb 22, 2024

mwtoews commented Feb 22, 2024

scharlton2 commented Feb 22, 2024

scharlton2 commented Feb 22, 2024 • edited Loading

mwtoews commented Feb 22, 2024

mwtoews commented Feb 22, 2024

scharlton2 commented Feb 22, 2024

scharlton2 commented Feb 22, 2024

github-actions bot commented Feb 22, 2024

github-actions bot commented Feb 22, 2024

github-actions bot commented Feb 22, 2024

github-actions bot commented Feb 22, 2024

scharlton2 commented Feb 23, 2024

mwtoews commented Feb 23, 2024

scharlton2 commented Feb 23, 2024

scharlton2 commented Feb 23, 2024 • edited Loading

scharlton2 commented Apr 30, 2024

scharlton2 commented Feb 16, 2024 •

edited

Loading

mwtoews commented Feb 21, 2024 •

edited

Loading

scharlton2 commented Feb 22, 2024 •

edited

Loading

scharlton2 commented Feb 23, 2024 •

edited

Loading