-
-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate PyPy3 installers #657
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| @ECHO OFF | ||
| set "title=PyPy support is now deprecated!" | ||
| set "message=PyPy support is now deprecated! Future Miniforge releases will NOT build installers with PyPy in their base environment. We advise you switch to Miniforge at your earliest convenience. More details at https://conda-forge.org/news/2024/08/14/sunsetting-pypy/. If you require PyPy, you may pin your installer to one found in https://github.com/conda-forge/miniforge/releases/tag/24.7.1-0" | ||
| if "%GITHUB_ACTIONS%"=="true" ( | ||
| echo ::warning title=%title%::%message% | ||
| ) else ( | ||
| powershell "(New-Object -ComObject Wscript.Shell).Popup('%message%',0,'%title%',0x30)" >NUL | ||
| ) | ||
|
|
||
| for /f "delims=" %%# in ('powershell get-date -format "{yyyy-MM-dd}"') do @set _date=%%# | ||
| if "%_date%"=="2024-10-01" exit 1 | ||
| if "%_date%"=="2024-10-15" exit 1 | ||
| if "%_date%"=="2024-11-01" exit 1 | ||
| if "%_date%"=="2024-11-10" exit 1 | ||
| if "%_date%"=="2024-11-20" exit 1 | ||
| if "%_date%"=="2024-11-30" exit 1 | ||
| if "%_date%"=="2024-12-05" exit 1 | ||
| if "%_date%"=="2024-12-10" exit 1 | ||
| if "%_date%"=="2024-12-15" exit 1 | ||
| if "%_date%"=="2024-12-20" exit 1 | ||
| if "%_date%"=="2024-12-25" exit 1 | ||
| if "%_date%"=="2024-12-30" exit 1 | ||
| if "%_date%"=="2024-12-31" exit 1 | ||
| if "%_date:~0,4%"=="2025" exit 1 | ||
|
|
||
| echo Sleeping for 30s... | ||
| powershell -c "& {sleep 30}" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| #!/bin/bash | ||
|
|
||
| if [[ "$GITHUB_ACTIONS" == "true" ]]; then | ||
| echo "::warning title=Mambaforge is now deprecated!::Future Miniforge releases will NOT build Mambaforge installers. We advise you switch to Miniforge at your earliest convenience. More details at https://conda-forge.org/news/2024/07/29/sunsetting-mambaforge/." | ||
| else | ||
| echo "!!!!!! Conda-Forge PyPy is now deprecated !!!!!" | ||
| echo "Future Miniforge releases will NOT build with PyPy in the base environment installers." | ||
| echo "We advise you switch to Miniforge3 at your earliest convenience." | ||
| echo "More details at https://conda-forge.org/news/2024/08/14/sunsetting-pypy/" | ||
| echo "If you are unable to switch to Miniforge, you may pin your installer version to one found in " | ||
| echo "https://github.com/conda-forge/miniforge/releases/tag/24.3.0-1" | ||
| echo "or if you lack the system requirements (Linux glibc >= 2.17, or macOS + x86-64bit >= 10.13)" | ||
| echo "you may pin your installer to one older version found in " | ||
| echo "https://github.com/conda-forge/miniforge/releases/tag/24.3.0-0" | ||
| echo "This Miniforge installer will ceese to work in 2025." | ||
| fi | ||
|
|
||
| case $(date +%F) in | ||
| # Brownouts | ||
| 2024-10-01|2024-10-15|2024-11-01|2024-11-10|2024-11-20|2024-11-30|2024-12-05|2024-12-10|2024-12-15|2024-12-20|2024-12-25|2024-12-30|2024-12-31|2025-*) | ||
| exit 1 | ||
| ;; | ||
| *) | ||
| echo "Sleeping for 30s..." | ||
| sleep 30 | ||
| ;; | ||
| esac | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's put this in a text file that ships with the installer. Then all platforms can echo the test file and we can get the wording to match with both
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would rather not overbuild for a depreation that will only last 3 months.
The challenge is that the wording MUST be different for different platforms.
Windows, linux, and OSX have different recommendations.
Generic recommendations REALLY confuse first time users.
Is there a word here that you are concerned with getting correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My windows skills are also seriously lacking..... so I would rather not try something new....
My main goal for this week is to give time for somebody that might care for this installer to stepup, but not to create more organizational work. "2" notices is not enough to reorganize things IMO.