-
-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Discourage the usage of Mambaforge -- Update docs #488
Conversation
9a95024
to
92d3858
Compare
I'm fine with this messaging but would like to check how others in @conda-forge/core feel about it. Also, can you please take a look at #478 and conda-forge/conda-forge.github.io#1995? I think they all try to communicate the same so ideally we can just link to the blog post too. |
README.md
Outdated
download links of Mambaforge active to help those that have automated | ||
workflows. Because of this, as of September 2023, the new usage of Mambaforge | ||
is discouraged. Bug reports specific to Mambaforge will be closed as | ||
`wont-fix`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe that is missing here is something along the lines that the next mambaforge and miniforge releases will be virtually the same with the exception of shipping mamba in one vs the other, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mamba
is in both now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I may be wrong but I don't get that idea from this message. Maybe we should just say that above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The idea is that since both are equivalent, we are going to predominantly suggest using Miniforge and just keep Mambaforge around for backwards compatibility. Hence, if you need to start using our installers today, we are saying that you should go for Miniforge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep. That much us clear but functionality is different from identical. I may be exaggerating but instead of "the functionality of Mambaforge was incorporated into Miniforge." maybe something along the lines:
"as of release x.x.x Mambaforge and Miniforge are identical and we recommend the use of Miniforge b/c Mambaforge is just a link to it with the goal of preventing link rot."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess to me they were identical since they install to different default directories. I can make this more clear.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh. Yeah, to me too. I'm trying to read that as a user that is not 100% in tune with conda/conda-forge events and decisions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I finally sat down and read @jaimergp 's message on conda-forge/conda-forge.github.io#1995
I pulled most of his language.
f1873d1
to
d5b4e6f
Compare
d5b4e6f
to
7cef9a4
Compare
As of September 2023, the new usage of Mambaforge is thus discouraged. Bug | ||
reports specific to Mambaforge will be closed as won't fix. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is the only sentence of value I am suggesting to add.
I really don't want to spend time discussing any issues specific to Mambaforge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the only sentence I don't understand. Since Mambaforge and Miniforge3 are basically identical, I don't understand this specific sentence.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i feel like small bugs like this: #399
might keep coming up in the future, and I would like to respectfully close them reducing the complexity of our installers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah makes sense.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep. Identical is one thing, what users may request is another. Also, if we ever decide to stop publishing mambaforge, we need to make sure folks understand it is deprecated. Nothing like "no issues accept" to convey that message ;-p
leaving open until sept 21st for final comments, then merging. |
Co-authored-by: jaimergp <[email protected]>
Co-authored-by: jaimergp <[email protected]>
cc: @jaimergp
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)