Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove vendored dependencies #3

Open
traversaro opened this issue Jan 7, 2021 · 2 comments
Open

Remove vendored dependencies #3

traversaro opened this issue Jan 7, 2021 · 2 comments

Comments

@traversaro
Copy link
Contributor

osqp contains some vendored dependencies (qdldl and amd from suitesparse) that it would be a good idea to remove and use proper recipes instead to avoid tricky ABI issues in the future. From the discussion in osqp/osqp#85 it may be necessary to still use the vendored qdldl and amd for code generation, but as code generation is something only available at high level (Python and MATLAB) we can see how to deal with it at the osqp-feedstock level, that mantains the osqp Python bindings.

@traversaro
Copy link
Contributor Author

This is related to conda-forge/scs-feedstock#18 as well, given that scs vendors exactly the same dependencies (qdldl and amd from suitesparse).

@h-vetinari
Copy link
Member

With #8 we have now gotten rid of qdldl at least. The suitesparse bits would be nice to get rid of as well, but they seem to be really old (2015 judging by the license, though at least 2018; haven't dug back further in the git history), so I'm not sure if they're drop-in recompilable with a current suitesparse.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants