-
-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
REF: Split off static libraries and binary artifacts into separate outputs #32
base: main
Are you sure you want to change the base?
Conversation
…nda-forge-pinning 2024.02.29.20.54.57
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipe:
For recipe:
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipe:
|
# Binary package; this is the exported name from the pre-multi-output recipe | ||
- name: libjpeg-turbo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because this output contains or depends on all binaries, named-libraries, manpages, and examples; no downstream packages should break. However, downstream recipes will need to migrate themselves to libjpeg-turbo-dev
the next time they are built.
why not just remove outright the static libraries. are we really interested in maintaining static workflows? |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipe/meta.yaml:
|
This PR now relies on the conda-build v24.7 package which was recently released on the defaults channel, but has not yet been released on conda-forge. |
@conda-forge-admin, please rerender |
…nda-forge-pinning 2024.08.15.15.10.41
is there a need for the static library? it may have just been included by accident 6 years ago. |
There is no static library subpackage in the latest revision of this PR. I removed it after your previous request to remove it from the recipe. |
ok maybe the title needs to be updated. Are you still interested in doing so much work on this recipe? Would it be acceptable to just set STATIC=0 and move on? or do you want to remove any other files? I find that maybe the documentation files don't really belong here. It seems the world has moved on to online documentation. |
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)This PR splits the artifacts into smaller packages according to their type according to the "build everything, then split" method. The compilation is performed in the top-level package and installed to a staging folder instead of the $PREFIX. Then for each output, an install script decides which files are moved to the prefix using pattern matching.
Note that in this recipe, I have placed the libjpeg and libjpegturbo artifacts into separate outputs because they have different SO names. However, the number of outputs could be reduced by one if the static libraries were shipped together instead of separately.
Why? I'm slowly working throught my dependency tree and trying to eliminate static libraries from my end-user environments. Our channel also has a CFEP against static libaries being shipped in the default output of a recipe.