Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split off headers into libcxx-devel #190

Merged
merged 4 commits into from
Sep 3, 2024
Merged

Conversation

h-vetinari
Copy link
Member

Redo #183 after #187 and conda-forge/clangdev-feedstock#311 prepared the way.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

- {{ pin_subpackage("libcxx", exact=True) }}
- {{ pin_subpackage("libcxx", max_pin=None) }}
Copy link
Member Author

@h-vetinari h-vetinari Aug 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I think I get now how this solves conda-forge/clangdev-feedstock#310.

If we're using the libcxx-devel 16.x headers to compile something, while having libcxx 20 in the environment, that does run the risk of running into minor ABI differences (and potentially missing symbols, if some got removed in later libcxx), but that's still essentially the same standpoint as we have already, i.e. "libcxx is essentially ABI-stable (and the enormous effort to properly handle any differences isn't worth it, given the relative rarity of breaks)"

@h-vetinari
Copy link
Member Author

Failing tests against clang 15 were fixed by conda-forge/libcxx-testing-feedstock#12. This should be ready IMO.

this does not seem necessary to build, and prevents us from letting `clangxx`
depend on `libcxx-devel` (because it would create a build cycle); see
conda-forge/clangdev-feedstock#315 (comment)
@isuruf isuruf merged commit 66e861f into conda-forge:main Sep 3, 2024
10 checks passed
@h-vetinari h-vetinari deleted the devel branch September 3, 2024 22:38
@h-vetinari h-vetinari mentioned this pull request Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants