Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to the latest compilers on conda-forge #94

Closed
wants to merge 9 commits into from

Conversation

certik
Copy link
Contributor

@certik certik commented Aug 24, 2024

Important: this requires using LLVM 17 on osx, but LFortran does not work with LLVM 17 yet (it compiles, but only a few tests work so far): lfortran/lfortran#4210. So this PR must stay a draft, until we fully support LLVM 17 in LFortran. Until then this PR is to ensure that at least the conda packages can be built on all platforms.

TODO:

In the worst case, if we are blocked by the second issue, we can drop macOS / intel support, since eventually it will get dropped anyway once most people move on to Apple Silicon. The first issue however is a blocker. We need to fix that in LFortran first.

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@certik
Copy link
Contributor Author

certik commented Aug 24, 2024

@conda-forge-admin, please rerender

@certik
Copy link
Contributor Author

certik commented Aug 24, 2024

The only issue is linking on osx (intel):

[ 85%] Linking CXX executable lfortran
Undefined symbols for architecture x86_64:
  "__availability_version_check", referenced from:
      ___isPlatformVersionAtLeast in libclang_rt.osx.a(os_version_check.c.o)
      __initializeAvailabilityCheck in libclang_rt.osx.a(os_version_check.c.o)
ld: symbol(s) not found for architecture x86_64
x86_64-apple-darwin13.4: error: linker command failed with exit code 1 (use -v to see invocation)

This issue happens with both 0.39.0 (which works with Clang 16) and 0.40.0, so it is caused by the upgrade of Clang from 16 to 17.

Everything else seems to work.

@certik
Copy link
Contributor Author

certik commented Aug 24, 2024

@conda-forge-admin, please rerender

@certik certik changed the title Llvm update3 Update to the latest compilers on conda-forge Aug 24, 2024
Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/lfortran-feedstock/actions/runs/10541415336.

@certik
Copy link
Contributor Author

certik commented Aug 24, 2024

Still the same linker error even after enforcing libcxx 17.

@certik
Copy link
Contributor Author

certik commented Oct 15, 2024

Closing in favor of #102.

@certik certik closed this Oct 15, 2024
@certik certik deleted the llvm_update3 branch October 15, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant