Update to version 1.2 #2

ps-git · 2019-11-02T15:59:19Z

Checklist

Used a fork of the feedstock to propose changes
Reset the build number to 0 (if the version changed)
Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
Ensured the license file is being packaged.

Updates release version to latest released (1.2)

conda-forge-linter · 2019-11-02T16:00:56Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

conda-forge-linter · 2019-11-02T16:09:39Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

Whenever possible python packages should use pip. See https://conda-forge.org/docs/maintainer/adding_pkgs.html#use-pip

Update to PIP

conda-forge-linter · 2019-11-02T16:16:22Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

Cleaned up summary

Reset package name. Update License

recipe/meta.yaml

CJ-Wright · 2019-11-02T16:58:17Z

recipe/meta.yaml

-  dev_url: https://github.com/ianozsvald/ipython_memory_usage
+  license_file: LICENSE
+  summary:
+    - IPython tool to report memory usage deltas for every command you type. If you are running out of RAM then use this tool to understand what’s happening. It also records the time spent running each command.


I think this needs to be a single string

This seems ok as is.

This is still a list, not a string

CJ-Wright · 2019-11-02T16:58:45Z

@conda-forge-admin please rerender

…nda-forge-pinning 2019.11.01

Updated test. No direct ipython call possible

Enhanced tests to import ipython_memory_usage module

conda-forge-linter · 2019-11-02T18:11:36Z

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

The recipe must have some tests.
The test section contained an unexpected subsection name. command is not a valid subsection name.

conda-forge-linter · 2019-11-02T18:14:07Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

recipe/meta.yaml

- Move SHA256 hash into yaml. (As suggested in PR) - Remove fn: as not required.

xhochy · 2019-11-03T17:28:50Z

@ps-git Can you take care of the remaining comments or should I take over?

ps-git · 2019-11-03T17:34:26Z

@ps-git Can you take care of the remaining comments or should I take over?

If you could have a look at the last one.

Replacing 'build:' with 'host:'.

It works fine in conda build as is.

Thank you for your help with this.

xhochy · 2019-11-03T17:45:09Z

@ps-git Can you take care of the remaining comments or should I take over?

If you could have a look at the last one.

Replacing 'build:' with 'host:'.

It works fine in conda build as is.

Thank you for your help with this.

It might work but host is meant for "compile-time" dependencies whereas build is for build tools like a compiler.

ps-git · 2019-11-03T17:46:13Z

@ps-git Can you take care of the remaining comments or should I take over?

If you could have a look at the last one.

Replacing 'build:' with 'host:'.

It works fine in conda build as is.
Thank you for your help with this.

It might work but host is meant for "compile-time" dependencies whereas build is for build tools like a compiler.

Thank you for clarifying. I will make the change.

ps-git added 2 commits November 2, 2019 15:40

Update meta.yaml

04698e0

Add Variables

008e4d4

Update meta.yaml

3a4f9f5

Update meta.yaml

4aebd3a

Update to PIP

ps-git added 4 commits November 2, 2019 16:18

Update meta.yaml

7be56e2

Update meta.yaml

36a7f74

Update meta.yaml

3862f4a

Cleaned up summary

Update meta.yaml

895e708

Reset package name. Update License

CJ-Wright reviewed Nov 2, 2019

View reviewed changes

recipe/meta.yaml Show resolved Hide resolved

CJ-Wright reviewed Nov 2, 2019

View reviewed changes

recipe/meta.yaml Outdated Show resolved Hide resolved

CJ-Wright reviewed Nov 2, 2019

View reviewed changes

recipe/meta.yaml Outdated Show resolved Hide resolved

CJ-Wright reviewed Nov 2, 2019

View reviewed changes

conda-forge-admin and others added 3 commits November 2, 2019 16:59

MNT: Re-rendered with conda-build 3.18.10, conda-smithy 3.6.1, and co…

4463b9e

…nda-forge-pinning 2019.11.01

Update meta.yaml

5ff0d1e

Updated test. No direct ipython call possible

Update meta.yaml

49c9754

ianozsvald mentioned this pull request Nov 2, 2019

Update meta.yaml #1

Closed

5 tasks

Update meta.yaml

2ce0288

Enhanced tests to import ipython_memory_usage module

Meta.yaml - Change command to commands

2f8fa96

xhochy reviewed Nov 2, 2019

View reviewed changes

recipe/meta.yaml Outdated Show resolved Hide resolved

xhochy reviewed Nov 2, 2019

View reviewed changes

recipe/meta.yaml Outdated Show resolved Hide resolved

recipe/meta.yaml Show resolved Hide resolved

Clean-up meta.yaml

ea8a7c5

- Move SHA256 hash into yaml. (As suggested in PR) - Remove fn: as not required.

ps-git and others added 2 commits November 3, 2019 17:49

Update requirements (replace build with host)

6afb955

Make summary a single string

bd2857f

xhochy merged commit 659bf1e into conda-forge:master Nov 5, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update to version 1.2 #2

Update to version 1.2 #2

ps-git commented Nov 2, 2019

conda-forge-linter commented Nov 2, 2019

conda-forge-linter commented Nov 2, 2019

conda-forge-linter commented Nov 2, 2019

CJ-Wright Nov 2, 2019

ps-git Nov 3, 2019

xhochy Nov 3, 2019

CJ-Wright commented Nov 2, 2019

conda-forge-linter commented Nov 2, 2019

conda-forge-linter commented Nov 2, 2019

xhochy commented Nov 3, 2019

ps-git commented Nov 3, 2019 •

edited

Loading

xhochy commented Nov 3, 2019

ps-git commented Nov 3, 2019

Update to version 1.2 #2

Update to version 1.2 #2

Conversation

ps-git commented Nov 2, 2019

conda-forge-linter commented Nov 2, 2019

conda-forge-linter commented Nov 2, 2019

conda-forge-linter commented Nov 2, 2019

CJ-Wright Nov 2, 2019

Choose a reason for hiding this comment

ps-git Nov 3, 2019

Choose a reason for hiding this comment

xhochy Nov 3, 2019

Choose a reason for hiding this comment

CJ-Wright commented Nov 2, 2019

conda-forge-linter commented Nov 2, 2019

conda-forge-linter commented Nov 2, 2019

xhochy commented Nov 3, 2019

ps-git commented Nov 3, 2019 • edited Loading

xhochy commented Nov 3, 2019

ps-git commented Nov 3, 2019

ps-git commented Nov 3, 2019 •

edited

Loading