Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Set python_min of Python 3.8 #59

Merged
merged 2 commits into from
Nov 11, 2024

Conversation

matthewfeickert
Copy link
Member

@matthewfeickert matthewfeickert commented Nov 8, 2024

Description

  • Use python {{ python_min }} syntax for the python requirements for noarch python recipes.
  • Add recipe/conda_build_config.yaml to override the global python_min with hatchling's python_min of 3.8.
  • Install with recommended --no-deps --no-build-isolation options to ensure build dependencies are correct.
  • Update to pypi.org.
  • Bump build number.

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • [N/A] Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

* Use 'python {{ python_min }}' syntax for the python requirements for noarch
  python recipes.
   - c.f. https://conda-forge.org/docs/maintainer/knowledge_base/#noarch-python
* Add recipe/conda_build_config.yaml to override the global python_min with hatchling's
  python_min of 3.8.
* Install with recommended --no-deps --no-build-isolation options to ensure build
  dependencies are correct.
* Update to 'pypi.org'.
* Bump build number.
@matthewfeickert
Copy link
Member Author

@conda-forge-admin, please rerender

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.
I do have some suggestions for making it better though...

For recipe/meta.yaml:

  • No valid build backend found for Python recipe for package hatchling using pip. Python recipes using pip need to explicitly specify a build backend in the host section. If your recipe has built with only pip in the host section in the past, you likely should add setuptools to the host section of your recipe.

@matthewfeickert
Copy link
Member Author

  • No valid build backend found for Python recipe for package hatchling using pip. Python recipes using pip need to explicitly specify a build backend in the host section. If your recipe has built with only pip in the host section in the past, you likely should add setuptools to the host section of your recipe.

I assume that build backends are immune from this. I'm not sure if there is some way to indicate to conda-forge that they are self sufficient.

@matthewfeickert matthewfeickert marked this pull request as ready for review November 8, 2024 08:32
@matthewfeickert matthewfeickert requested a review from ofek as a code owner November 8, 2024 08:32
@matthewfeickert
Copy link
Member Author

@conda-forge/hatchling this is ready for review.

Copy link
Contributor

@ofek ofek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thank you!

@ofek ofek merged commit 2cbff75 into conda-forge:main Nov 11, 2024
4 checks passed
@matthewfeickert matthewfeickert deleted the fix/set-correct-python-min branch November 11, 2024 06:25
@matthewfeickert
Copy link
Member Author

Thanks @ofek. Can I also get you to 👍 conda-forge/conda-forge-repodata-patches-feedstock#901 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect minimum Python version
3 participants