-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump version to 2022.05.001 #17
base: main
Are you sure you want to change the base?
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@conda-forge-admin, please rerender |
…nda-forge-pinning 2022.11.13.03.29.29
Thanks for your interest in (co-)maintaining this feedstock. Looks like the preprocessing on OSX is causing issues again, it needs cpp which I previously sneaked in via gfortran: elpa-feedstock/recipe/build.sh Line 28 in 84cd3cc
|
Thanks for this! I will fix it tomorrow, you've just saved me an hour of work. :) I have also noticed (unrelated to this) that Elpa was the reason why one of my program segfaults on ivybridge. If that is OK, I'll probably rework the build script to provide architecture-specific variants. Elpa does not seem do any function multiversioning and looking at the code, which is very "imperative-oriented" if that makes sense, introducing multiversioning would take a tremendous amount of time so I suppose providing variants and defaulting to the generic implementation makes sense. |
Elpa doesn't provide any micro-arch cross-compiliation features as far as I know, so you have to decide ad hoc which kernels to include and which to set as default, while your kernel features are limited by the build machine micro-arch. As default the most sophisticated kernel is chosen, but can be changed on the user side. In principle you should be able to fallback to the generic kernel with any version of Elpa, at least that is my understanding. |
Elpa literally segfaults on Ivybridge so there is either a bug or selection is done at compile time (skimming through the code, in the midst of a thousand conditions, it looks like this is what is done).
Well, either compiled code is directly used at compile time to actively limit portability or no one ever cared to compile the kernels with the correct compiler flags. Either way, really nothing these days prevents micro-arch compilation: Openblas, FFTW and BLIS (to give relevant examples) all provide micro-arch-optimised kernels at runtime. You saved me an hour of looking for things, I'll have a closer look at Elpa to get things work (if indeed uarch selection is a thing). |
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)