Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added LICENSE file #6

Merged
merged 4 commits into from
Jan 6, 2022
Merged

Conversation

mmccarty
Copy link
Contributor

@mmccarty mmccarty commented Jan 5, 2022

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@jakirkham
Copy link
Member

Hi Mike, thanks for the PR

Can you please share some more context about this? The source code already contains the license file, which we include in the packages here

@mmccarty
Copy link
Contributor Author

mmccarty commented Jan 5, 2022

Thanks @jakirkham Sorry, I meant to add context but got distracted. Someone pointed out to me that the license linked from https://anaconda.org/conda-forge/cuda-python results in a 404. I believe the license_file in recipe/meta.yml is relative to the recipe directory. Adding the file there should fix it?

@leofang
Copy link
Member

leofang commented Jan 5, 2022

@mmccarty If you're referring to the hyperlink LicenseRef-NVIDIA-SOFTWARE-LICENSE, you should just add one more entry license_url to meta.yaml pointing to CUDA Python's license page. This will not work.

@jakirkham
Copy link
Member

Thanks for the context Mike. No worries 🙂

Agree with Leo. Would also suggest re-rendering after making that change.

@leofang
Copy link
Member

leofang commented Jan 5, 2022

@jakirkham That said, I do notice a few other feedstocks have incorrect hyperlinks too, even though license_url has been added:

However, the license link of cuTENSOR (https://anaconda.org/conda-forge/cutensor) works. I suspect it has to to with the "LicenseRef-" prefix that we added to suppress the linter complaint (when cuTENSOR was added to conda-forge, it started without the prefix; it's added later after the initial package already lived on anaconda.org). I think there is a bug somewhere in anaconda.org's hyperlink handling (as I checked and didn't spot anything odd in conda-build or conda-smithy).

@jakirkham
Copy link
Member

Could you please raise new issues on those feedstocks regarding these links?

@mmccarty
Copy link
Contributor Author

mmccarty commented Jan 5, 2022

@conda-forge-admin, please rerender

@mmccarty
Copy link
Contributor Author

mmccarty commented Jan 5, 2022

@leofang @jakirkham Looks like that did the trick. At least for the ReadMe. Thanks!

@leofang
Copy link
Member

leofang commented Jan 5, 2022

Could you please raise new issues on those feedstocks regarding these links?

Thanks @jakirkham for a few good catches, I narrow it down to this list:

@jakirkham
Copy link
Member

Thanks Leo! 😄 Will follow up in those issues

@leofang
Copy link
Member

leofang commented Jan 6, 2022

Let's see if this change would get the hyperlink fixed on anaconda.org! (My guess is it would not.)

@leofang leofang merged commit 7145e16 into conda-forge:master Jan 6, 2022
@jakirkham
Copy link
Member

If it doesn't, let's open an issue on this feedstock and we can go from there

@mmccarty
Copy link
Contributor Author

mmccarty commented Jan 6, 2022

Looks like it's still broken. Opened an issue #7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants