-
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added LICENSE file #6
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
…nda-forge-pinning 2022.01.05.14.36.24
Hi Mike, thanks for the PR Can you please share some more context about this? The source code already contains the license file, which we include in the packages here |
Thanks @jakirkham Sorry, I meant to add context but got distracted. Someone pointed out to me that the license linked from https://anaconda.org/conda-forge/cuda-python results in a 404. I believe the |
@mmccarty If you're referring to the hyperlink |
Thanks for the context Mike. No worries 🙂 Agree with Leo. Would also suggest re-rendering after making that change. |
@jakirkham That said, I do notice a few other feedstocks have incorrect hyperlinks too, even though However, the license link of cuTENSOR (https://anaconda.org/conda-forge/cutensor) works. I suspect it has to to with the "LicenseRef-" prefix that we added to suppress the linter complaint (when cuTENSOR was added to conda-forge, it started without the prefix; it's added later after the initial package already lived on anaconda.org). I think there is a bug somewhere in anaconda.org's hyperlink handling (as I checked and didn't spot anything odd in conda-build or conda-smithy). |
Could you please raise new issues on those feedstocks regarding these links? |
@conda-forge-admin, please rerender |
…nda-forge-pinning 2022.01.05.14.36.24
@leofang @jakirkham Looks like that did the trick. At least for the ReadMe. Thanks! |
Thanks @jakirkham for a few good catches, I narrow it down to this list: |
Thanks Leo! 😄 Will follow up in those issues |
Let's see if this change would get the hyperlink fixed on anaconda.org! (My guess is it would not.) |
If it doesn't, let's open an issue on this feedstock and we can go from there |
Looks like it's still broken. Opened an issue #7 |
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)