Add cuda.core v0.1.1 as an output
#102
Conversation
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
…onda-forge-pinning 2024.12.21.10.18.30
|
@conda-forge-admin, please rerender |
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipe/meta.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12477394373. Examine the logs at this URL for more detail. |
…onda-forge-pinning 2024.12.23.13.01.35
leofang
requested review from
bdice,
jakirkham,
leofang,
m3vaz,
mmccarty,
vyasr and
vzhurba01
as code owners
| {% set pkg_ver = major_version ~ "." ~ minor_version ~ "." ~ patch_version %} | ||
| {% if major_version != 0 %} | ||
| {% set building_bindings = true %} | ||
| {% set building_core = false %} | ||
| {% set tag = "v" ~ pkg_ver %} | ||
| {% set number = 2 %} | ||
| {% else %} | ||
| {% set building_bindings = false %} | ||
| {% set building_core = true %} | ||
| {% set tag = "cuda-core-v" ~ pkg_ver %} | ||
| {% set number = 0 %} | ||
| {% endif %} |
There was a problem hiding this comment.
With this PR, this feedstock starts to produce multiple outputs. In the future it'd be
cuda-corecuda-bindingscuda-python
as described in the upstream issue (NVIDIA/cuda-python#105). For this particular tag, however, we only release cuda-core and the bindings should be kept intact, so a deselection logic is implemented here to only build cuda-core. We'll need to figure out how the logic looks like depending on the situation of future releases. Right now we're still experimenting so this is OK.
| {% set target_name = "x86_64-linux" %} # [linux64] | ||
| {% set target_name = "sbsa-linux" %} # [aarch64] | ||
| {% set target_name = "x64" %} # [win64] | ||
| {% set subdir = "" %} |
There was a problem hiding this comment.
For some reason conda-smithy is not happy without a default value (jinja parsing failed with "subdir undefined".
There was a problem hiding this comment.
Note: we add the per-package, per-OS silly build scripts here because the usual {{ PYTHON }} trick that we apply to multi-output recipes no longer works for some reason... It seems the Jinja expansion order has changed in conda-smithy recently? Using the scripts is a workaround for the Jinja issue.
| build: | ||
| number: {{ number }} | ||
| # cuda.bindings needs to be built with the matching major.minor headers | ||
| {% if not (environ.get("cuda_compiler_version")|string()) == (major_version ~ "." ~ minor_version) %} |
There was a problem hiding this comment.
Note: This skip condition has been updated to ensure the requirement is visible in the recipe level, not in the private migrator level. In fact, the migrator has caused trouble during rerendering, so I simply removed it. I checked that the new recipe here builds fine (if we revert the deselection logic to build cuda-python).
Hi! This is the friendly automated conda-forge-webservice.
I've started rerendering the recipe as instructed in #101.
If I find any needed changes to the recipe, I'll push them to this PR shortly. Thank you for waiting!
Here's a checklist to do before merging.
Fixes #101
xref: conda-forge/admin-requests#1243