-
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more tests to make sure the package does not regress. #7
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
83b3bf7
to
a23e2cf
Compare
@mcbarton, @fsfod, we seem to have a similar problem to the one we fixed in compiler-research/CppInterOp#196. I see that some of the exports are dependent on the MSVC version and I was wondering if we can carry these exports somehow in the |
@conda-forge-admin, please rerender |
…nda-forge-pinning 2024.03.19.07.11.10
ccb1f26
to
d308ba2
Compare
@vgvassilev The export symbols method is known to be brittle to the version of MSVC used compiler-research/CppInterOp#188 (comment) . @fstod discusses his opinion on WINDOWS_EXPORT_ALL_SYMBOLS in this message, suggestion he doesn't think it will work. He also suggests a longer term solution than these methods. |
Yes. Understood. I believe compiler-research/CppInterOp#213 fixes my problem for now... |
@conda-forge-admin, please rerender |
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)