Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add output to gitignore #2222

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add output to gitignore #2222

wants to merge 2 commits into from

Conversation

pavelzw
Copy link
Member

@pavelzw pavelzw commented Jan 17, 2025

Checklist

  • Added a news entry
  • Regenerated schema JSON if schema altered (python conda_smithy/schema.py)

@pavelzw pavelzw marked this pull request as ready for review January 17, 2025 10:53
@pavelzw pavelzw requested a review from a team as a code owner January 17, 2025 10:53
Comment on lines +25 to +27

# Rattler-build's artifacts are in `output` when not specifying anything.
/output
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this needed? Can you give an example where this is useful?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When i'm working on a fork locally, i tend to just run rattler-build build -r ./recipe -m .ci_support/... and then inspect the files in output.

Similar to conda-forge/staged-recipes@ac581d5

Copy link
Member

@isuruf isuruf Jan 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you send me the output on your machine from the following code?

git clone [email protected]:conda-forge/numpy-feedstock
cd numpy-feedstock
mkdir output
touch output/foo
git diff
git status

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❯ git clone [email protected]:conda-forge/numpy-feedstock
  cd numpy-feedstock
  mkdir output
  touch output/foo
  git diff
  git status
Cloning into 'numpy-feedstock'...
remote: Enumerating objects: 5046, done.
remote: Counting objects: 100% (2087/2087), done.
remote: Compressing objects: 100% (248/248), done.
remote: Total 5046 (delta 1957), reused 1860 (delta 1839), pack-reused 2959 (from 2)
Receiving objects: 100% (5046/5046), 729.69 KiB | 1.90 MiB/s, done.
Resolving deltas: 100% (3830/3830), done.
On branch main
Your branch is up to date with 'origin/main'.

nothing to commit, working tree clean

Interestingly, it doesn't happen here.

In conda-forge/polars-feedstock#303 for example, you get this issue because some files in the output directory are .gitignore files that explicitly unignore some files:
like jemalloc-sys here for example
image

In the conda-forge/polars-feedstock#303 example you get 510 files that are explicitly unignored.

Also, only * in .gitignore results in VSCode still checking all directories for potential .gitignore files which makes it unresponsive in some cases (for example in rust with large target/ directories)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants