Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: rename v2 to v1 and v1 to v0 #2031

Merged
merged 9 commits into from
Aug 9, 2024
Merged

fix: rename v2 to v1 and v1 to v0 #2031

merged 9 commits into from
Aug 9, 2024

Conversation

beckermr
Copy link
Member

@beckermr beckermr commented Aug 9, 2024 •
edited
Loading

Checklist

  • Added a news entry
  • Regenerated schema JSON if schema altered (python conda_smithy/schema.py)

closes #2030

beckermr
beckermr commented Aug 9, 2024
View reviewed changes
Copy link
Member Author

@beckermr beckermr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I missed a few items.

news/rename-v2-v1.rst Outdated Show resolved Hide resolved
tests/test_lint_recipe.py Outdated Show resolved Hide resolved
@wolfv
Copy link
Member

wolfv commented Aug 9, 2024

Yeeeeeeeees! Nice work on getting it green! :)

wolfv
wolfv approved these changes Aug 9, 2024
View reviewed changes
Copy link
Member

@wolfv wolfv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Matt!

@beckermr beckermr marked this pull request as ready for review August 9, 2024 15:56
@beckermr beckermr requested a review from a team as a code owner August 9, 2024 15:56
@beckermr beckermr merged commit 538aee5 into main Aug 9, 2024
2 checks passed
@wolfv wolfv deleted the v2-to-v1 branch August 9, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wolfv wolfv wolfv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

rename v2 to v1
2 participants
@beckermr @wolfv