Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix MatchSpec parsing when remote_ci_setup specs are quoted #1775

Merged
merged 6 commits into from
Sep 26, 2023
Merged

Fix MatchSpec parsing when remote_ci_setup specs are quoted #1775

merged 6 commits into from
Sep 26, 2023

Conversation

jaimergp
Copy link
Member

@jaimergp jaimergp commented Sep 26, 2023 •
edited
Loading

Checklist

  • Added a news entry

Closes #1773

@jaimergp jaimergp changed the title sanitization might quote the string, breaking the matchspec parser Fix MatchSpec parsing when remote_ci_setup specs are quoted Sep 26, 2023
@jaimergp jaimergp marked this pull request as ready for review September 26, 2023 14:07
@jaimergp jaimergp requested a review from a team as a code owner September 26, 2023 14:07
@jaimergp
Copy link
Member Author

@h-vetinari - fix is ready!

h-vetinari
h-vetinari approved these changes Sep 26, 2023
View reviewed changes
Copy link
Member

@h-vetinari h-vetinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the quick fix! 🙏

@beckermr beckermr merged commit c7e5a85 into conda-forge:main Sep 26, 2023
2 checks passed
@h-vetinari
Copy link
Member

I don't know how much work a new smithy-release is, but it would be helpful to have this available to unbreak rerendering for those feedstocks which have a remote_ci_setup with <. Is that realistic?

@jakirkham
Copy link
Member

Think this was picked up in the 3.26.3 release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@h-vetinari h-vetinari h-vetinari approved these changes

@beckermr beckermr beckermr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remote-ci-setup handling cannot handle constraints anymore (since conda-smithy 3.26)
4 participants
@jaimergp @h-vetinari @jakirkham @beckermr