Only use spec names with conda update, mamba and uninstalls are fine

conda_smithy/configure_feedstock.py

@@ -2036,10 +2036,13 @@ def _load_forge_config(forge_dir, exclusive_config_file, forge_yml=None):
     config["remote_ci_setup"] = _santize_remote_ci_setup(
         config["remote_ci_setup"]
     )
-    config["remote_ci_setup_names"] = [
-        MatchSpec(pkg.strip('"').strip("'")).name
-        for pkg in config["remote_ci_setup"]
-    ]
+    if config["conda_install_tool"] == "conda":
+        config["remote_ci_setup_update"] = [
+            MatchSpec(pkg.strip('"').strip("'")).name
+            for pkg in config["remote_ci_setup"]
+        ]
+    else:
+        config["remote_ci_setup_update"] = config["remote_ci_setup"]
 
     # Older conda-smithy versions supported this with only one
     # entry. To avoid breakage, we are converting single elements

conda_smithy/templates/build_steps.sh.tmpl

@@ -48,12 +48,12 @@ export CONDA_LIBMAMBA_SOLVER_NO_CHANNELS_FROM_INSTALLED=1
 
 {{ conda_install_tool }} install --update-specs --yes --quiet --channel conda-forge --strict-channel-priority \
     pip {{ conda_install_tool_deps }} {{ conda_build_tool_deps }} {{ " ".join(remote_ci_setup) }}
-{%- if conda_build_tool_deps != "" or conda_install_tool_deps != "" %}
+{%- if conda_install_tool == "mamba" and (conda_build_tool_deps != "" or conda_install_tool_deps != "") %}
 {{ conda_install_tool }} update --update-specs --yes --quiet --channel conda-forge --strict-channel-priority \
-    pip {{ conda_install_tool_deps }} {{ conda_build_tool_deps }} {{ " ".join(remote_ci_setup_names) }}
+    pip {{ conda_install_tool_deps }} {{ conda_build_tool_deps }} {{ " ".join(remote_ci_setup_update) }}
 {%- endif %}
 {% if local_ci_setup %}
-conda uninstall --quiet --yes --force {{ " ".join(remote_ci_setup_names)}}
+conda uninstall --quiet --yes --force {{ " ".join(remote_ci_setup)}}
 pip install --no-deps ${RECIPE_ROOT}/.
 {%- endif %}
 # set up the condarc

conda_smithy/templates/run_osx_build.sh.tmpl

@@ -40,13 +40,13 @@ export CONDA_LIBMAMBA_SOLVER_NO_CHANNELS_FROM_INSTALLED=1
 
 {{ conda_install_tool }} install --update-specs --quiet --yes --channel conda-forge --strict-channel-priority \
     pip {{ conda_install_tool_deps }} {{ conda_build_tool_deps }} {{ " ".join(remote_ci_setup) }}
-{%- if conda_build_tool_deps != "" or conda_install_tool_deps != "" %}
+{%- if conda_install_tool == "mamba" and (conda_build_tool_deps != "" or conda_install_tool_deps != "") %}
 {{ conda_install_tool }} update --update-specs --yes --quiet --channel conda-forge --strict-channel-priority \
-    pip {{ conda_install_tool_deps }} {{ conda_build_tool_deps }} {{ " ".join(remote_ci_setup_names) }}
+    pip {{ conda_install_tool_deps }} {{ conda_build_tool_deps }} {{ " ".join(remote_ci_setup_update) }}
 {%- endif %}
 
 {% if local_ci_setup %}
-conda uninstall --quiet --yes --force {{ " ".join(remote_ci_setup_names) }}
+conda uninstall --quiet --yes --force {{ " ".join(remote_ci_setup) }}
 pip install --no-deps {{ recipe_dir }}/.
 {%- endif %}
 

conda_smithy/templates/run_win_build.bat.tmpl

@@ -34,7 +34,7 @@ if !errorlevel! neq 0 exit /b !errorlevel!
 
 {%- if local_ci_setup %}
 echo Overriding conda-forge-ci-setup with local version
-conda.exe uninstall --quiet --yes --force {{ " ".join(remote_ci_setup_names) }}
+conda.exe uninstall --quiet --yes --force {{ " ".join(remote_ci_setup) }}
 if !errorlevel! neq 0 exit /b !errorlevel!
 pip install --no-deps ".\{{ recipe_dir }}\."
 if !errorlevel! neq 0 exit /b !errorlevel!

news/1774-update-names

@@ -0,0 +1,23 @@
+**Added:**
+
+* <news item>
+
+**Changed:**
+
+* Do not strip version constraints for ``mamba update``. (#1773 via #1774)
+
+**Deprecated:**
+
+* <news item>
+
+**Removed:**
+
+* <news item>
+
+**Fixed:**
+
+* <news item>
+
+**Security:**
+
+* <news item>

tests/test_configure_feedstock.py

@@ -917,12 +917,35 @@ def test_remote_ci_setup(config_yaml):
         ),
     )
     cfg = load_forge_config()
+    with open(os.path.join(config_yaml, "conda-forge.yml")) as fp:
+        unmodified = fp.read()
+
     with open(os.path.join(config_yaml, "conda-forge.yml"), "a+") as fp:
-        fp.write("remote_ci_setup: ['conda-forge-ci-setup=3', 'py-lief<0.12']")
+        fp.write(
+            "remote_ci_setup: ['conda-forge-ci-setup=3', 'py-lief<0.12']\n"
+        )
+        fp.write("conda_install_tool: conda\n")
     cfg = load_forge_config()
     # pylief was quoted due to <
     assert cfg["remote_ci_setup"] == [
         "conda-forge-ci-setup=3",
         '"py-lief<0.12"',
     ]
-    assert cfg["remote_ci_setup_names"] == ["conda-forge-ci-setup", "py-lief"]
+    assert cfg["remote_ci_setup_update"] == ["conda-forge-ci-setup", "py-lief"]
+
+    with open(os.path.join(config_yaml, "conda-forge.yml"), "w") as fp:
+        fp.write(unmodified + "\n")
+        fp.write(
+            "remote_ci_setup: ['conda-forge-ci-setup=3', 'py-lief<0.12']\n"
+        )
+        fp.write("conda_install_tool: mamba\n")
+    cfg = load_forge_config()
+    # with conda_install_tool = mamba, we don't strip constraints
+    assert (
+        cfg["remote_ci_setup"]
+        == cfg["remote_ci_setup_update"]
+        == [
+            "conda-forge-ci-setup=3",
+            '"py-lief<0.12"',
+        ]
+    )