Add emojis to visually distinguish between hints and lints #770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @beckermr |
|
pre-commit.ci autofix |
maresb
added a commit
to maresb/conda-smithy
that referenced
this pull request
Nov 9, 2024
Mirror the code from conda-forge/conda-forge-webservices#770
2 tasks
As I explain [here](conda-forge/conda-smithy#2126 (comment)) it can be really easy to miss the distinction between hints and linting errors. (The difference is indicated in a big block of boilerplate text.) Using ℹ️ for hints and ❌ for linter errors, I hope to make this easier to understand the severity at a glance.
|
This will potentially break some spacing hacks in hints with sub lists. Is there a way we can account for that with the emoji? |
maresb
changed the title
|
Hmm, can you point to an example so that I understand better? |
|
See this link: conda-forge/conda-smithy#2126. I used a precise number of spaces to format things properly. |
|
Also there are two linting paths. The one in use is the one in the GitHub actions integration submodule. We'll want to change that one too. |
Thanks, got it in f79e381 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As I explain here it can be really easy to miss the distinction between hints and linting errors. (The difference is indicated in a big block of boilerplate text.) Using ℹ️ for hints and ❌ for linter errors, I hope to make this easier to understand the severity at a glance.