Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

old libfabric builds conflict with new libfabric1 #931

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

minrk
Copy link
Member

@minrk minrk commented Dec 18, 2024

libfabric is now an empty metapackage, but the old packages are still allowed to be installed with the new libfabric1 because libfabric1 does not have run_constrains on libfabric

  • Used a static YAML file for the patch if possible (instructions).
  • Ran pre-commit run -a and ensured all files pass the linting checks.
  • Ran python show_diff.py and posted the output as part of the PR.
  • Modifications won't affect packages built in the future.
diff
================================================================================
================================================================================
linux-armv7l
================================================================================
================================================================================
win-32
================================================================================
================================================================================
osx-arm64
osx-arm64::libfabric-1.22.0-h5505292_0.conda
osx-arm64::libfabric-1.22.0-h5505292_1.conda
osx-arm64::libfabric-1.22.0-h5505292_2.conda
+  "constrains": [
+    "libfabric1 ==0.0.0"
+  ],
================================================================================
================================================================================
linux-ppc64le
linux-ppc64le::libfabric-1.15.2-h289c837_2.conda
linux-ppc64le::libfabric-1.17.0-h289c837_0.conda
linux-ppc64le::libfabric-1.19.1-h289c837_0.conda
linux-ppc64le::libfabric-1.19.1-h289c837_1.conda
linux-ppc64le::libfabric-1.22.0-h289c837_0.conda
linux-ppc64le::libfabric-1.22.0-h289c837_1.conda
linux-ppc64le::libfabric-1.22.0-h289c837_2.conda
+  "constrains": [
+    "libfabric1 ==0.0.0"
+  ],
================================================================================
================================================================================
linux-aarch64
linux-aarch64::libfabric-1.15.2-h4110fac_2.conda
linux-aarch64::libfabric-1.17.0-h4110fac_0.conda
linux-aarch64::libfabric-1.19.1-h4110fac_0.conda
linux-aarch64::libfabric-1.19.1-h4110fac_1.conda
linux-aarch64::libfabric-1.22.0-h4110fac_0.conda
linux-aarch64::libfabric-1.22.0-h4110fac_1.conda
linux-aarch64::libfabric-1.22.0-h4110fac_2.conda
+  "constrains": [
+    "libfabric1 ==0.0.0"
+  ],
================================================================================
================================================================================
noarch
================================================================================
================================================================================
win-64
================================================================================
================================================================================
osx-64
osx-64::libfabric-1.22.0-h6e16a3a_0.conda
osx-64::libfabric-1.22.0-h6e16a3a_1.conda
osx-64::libfabric-1.22.0-h6e16a3a_2.conda
+  "constrains": [
+    "libfabric1 ==0.0.0"
+  ],
================================================================================
================================================================================
linux-64
linux-64::libfabric-1.15.2-ha594dbc_2.conda
linux-64::libfabric-1.17.0-ha594dbc_0.conda
linux-64::libfabric-1.19.1-ha594dbc_0.conda
linux-64::libfabric-1.19.1-ha594dbc_1.conda
linux-64::libfabric-1.22.0-ha594dbc_0.conda
linux-64::libfabric-1.22.0-ha594dbc_1.conda
linux-64::libfabric-1.22.0-ha594dbc_2.conda
+  "constrains": [
+    "libfabric1 ==0.0.0"
+  ],

libfabric is now an empty metapackage, but the old packages are still allowed to be installed with the new libfabric1
because libfabric1 does not have run_constrains on libfabric
@minrk minrk requested a review from a team as a code owner December 18, 2024 16:56
@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@ocefpaf ocefpaf merged commit e92a2a4 into conda-forge:main Dec 19, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants